Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow entryFileNames, chunkFileNames functions for legacy #4122

Merged
merged 2 commits into from
Jul 11, 2021
Merged

feat: allow entryFileNames, chunkFileNames functions for legacy #4122

merged 2 commits into from
Jul 11, 2021

Conversation

avocadowastaken
Copy link
Contributor

@avocadowastaken avocadowastaken commented Jul 5, 2021

Description

Closes #3636

Additional context

I can't say that this solution will cover all the edge cases.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added plugin: legacy p2-nice-to-have Not breaking anything but nice to have (priority) labels Jul 5, 2021
@patak-dev
Copy link
Member

Thanks for the PR @umidbekk, this looks good. We should try to test this one on the current legacy playground though instead of creating a new playground, so we keep test suite run times at check. Would you try to refactor the new test there?

@avocadowastaken
Copy link
Contributor Author

avocadowastaken commented Jul 11, 2021

Thanks for the PR @umidbekk, this looks good. We should try to test this one on the current legacy playground though instead of creating a new playground, so we keep test suite run times at check. Would you try to refactor the new test there?

Done. I also found a bug - mutation of fileNames argument was a bad idea, so there are some source changes too.

patak-dev
patak-dev previously approved these changes Jul 11, 2021
Co-authored-by: Shinigami <chrissi92@hotmail.de>
@patak-dev patak-dev changed the title feat(plugin-legacy): Allow functions for entryFileNames and chunkFileNames. feat: allow entryFileNames, chunkFileNames functions for legacy Jul 11, 2021
@patak-dev patak-dev merged commit df29bff into vitejs:main Jul 11, 2021
@avocadowastaken avocadowastaken deleted the legacy-entry-names-function branch July 11, 2021 17:46
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy
Projects
None yet
3 participants