fix: create-vite when targetDir is a valid packageName

[spencer17x]

Description

fix create-vite without packageName

Additional context

isValidPackageName judgment

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[patak-dev]

The current code is doing what we intended, if the targetDir is a valid packageName, then the next question is ignored because it will be reused. We are only using that prompt if it is invalid.

@spencer17x would you create an issue to describe what problem did you run into?

[spencer17x]

@patak-js Now when it is created, although the project name is valid, the name of package.json is still empty. When the type is null, the problem is skipped directly, resulting in packageName being undefined

[patak-dev]

Good catch @spencer17x. The condition is still fine, I think we should modify this line

vite/packages/create-vite/index.js

Line 253 in 0316f14

pkg.name = packageName

to fallback to targetDir if packageName is undefined.

[spencer17x]

@patak-js I think so too, but considering that if the user expects the name of package.json to be inconsistent with the directory, this method requires the user to manually modify the name of package.json, so you think the method is better

[patak-dev]

@patak-js I think so too, but considering that if the user expects the name of package.json to be inconsistent with the directory, this method requires the user to manually modify the name of package.json, so you think the method is better

We discussed this with the team last time, and it was decided that we should enable people to chose a directory name that is not a valid package.json name. We also don't want to ask too many prompts, only the questions that are strictly needed. So the current approach is fine, but you found a bug. You could use this PR if you would like to fix it as we discussed 👍🏼

[spencer17x]

@patak-js So that's it, I understand, I modified it