fix(plugin-vue): exclude direct css request from hmr target #5422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes nuxt/nuxt#12211
This is really a tricky edge case. So here is the thing, normally this HMR should just work. But the way the plugin is implemented is by caching the style request from the main entry of Vue SFC. Normally the request will be something like
foo.vue?vue&type=style&lang.css
, which will be compiled to a js module with HMR capability like:However, if we do a direct request to the CSS - in Nuxt case, we do SSR to embedded the style to prevent FOUC like:
Base on the browser request header, the CSS plugin will then resolve the id with to
/foo.vue?direct&vue&type=style&lang.css
with the?direct
to serve plain CSS instead of js module.So now the direct request comes before the JS version, it makes the plugin internal state only record the direct one and send hmr event to the wrong module.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes nuxt/framework#123
).