-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to esm
dependency versions
#5840
Comments
Hello @Shinigami92. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it! |
esm
dependency versions
Related: node-fetch/node-fetch#1289 |
Maybe we can wait until after TypeScript 4.6 to do this. 🤔 |
TS 4.6 will come out before Vite 3.0 |
I'm confused because you said 4.6 but then linked to the 4.5 release notes |
Sorry, I forgot to explain clearly that TypeScript 4.5 delayed the official release of this feature and replaced it with an experimental feature, so we'd better wait until TypeScript 4.6. Experimental Nightly-Only ECMAScript Module Support in Node.js |
node.js support for TypeScript is in 4.7 |
Fixed in #8572 |
Clear and concise description of the problem
Currently there are some libraries (Vite is using) that only supports
esm
.Namely these are currently:
vite/.github/renovate.json5
Lines 32 to 35 in 00d8c9b
And execa: #5784
Suggested solution
I'm not quite sure what we need to do to support these 🤔
Maybe we need also to use
package.json
's"type": "module"
?Alternative
No response
Additional context
This also helps to archive #5839
Validations
The text was updated successfully, but these errors were encountered: