Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): compiler is null on rollup #6566

Merged
merged 1 commit into from
Jan 20, 2022
Merged

fix(plugin-vue): compiler is null on rollup #6566

merged 1 commit into from
Jan 20, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Jan 19, 2022

Description

There's no configResolved hook on Rollup, so I moved resolveCompiler to buildStart.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz sxzz changed the title fix(plugin-vue): compiler is null on rollup fix(plugin-vue): compiler is null on rollup Jan 19, 2022
@patak-dev patak-dev merged commit b289b2d into vitejs:main Jan 20, 2022
@patak-dev
Copy link
Member

We can release this as a minor for the plugin so projects can properly add the dependency range

@sxzz sxzz deleted the fix/vue-rollup branch January 20, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants