fix(plugin-vue): user defined transformAssetUrls ignored in production build #7171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever
options.devServer
isfalse
it overridesassetUrlOptions
, this makes it impossible to fully disabletransformAssetUrls
.Additional context
In my setup I have been trying to make rollup not import any
<img src="">
, this I fixed by overwriting the supported tagshttps://vue-loader.vuejs.org/options.html#transformasseturls
However this doesn't disable automatic srcset importing, for that I have to be able to fully set
transformAssetUrls
tofalse
but I'm unable to because of the override onvite build
. (see: https://github.com/vuejs/core/blob/main/packages/compiler-sfc/src/templateTransformSrcset.ts)See https://github.com/vuejs/core/blob/main/packages/compiler-sfc/src/compileTemplate.ts#L67, it should be able to support booleans:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).