Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): use crossorigin for nomodule #8322

Merged
merged 2 commits into from
Jun 1, 2022
Merged

fix(build): use crossorigin for nomodule #8322

merged 2 commits into from
Jun 1, 2022

Conversation

zuochenxue
Copy link
Contributor

Description

use crossorigin for nomodule

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

liaohainan
liaohainan reviewed May 25, 2022
View reviewed changes
Copy link

@liaohainan liaohainan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

patak-dev
patak-dev previously approved these changes Jun 1, 2022
View reviewed changes
@patak-dev patak-dev requested a review from sapphi-red June 1, 2022 11:40
@sapphi-red
Copy link
Member

linking for future reference: #6648

@patak-dev patak-dev merged commit 7f59989 into vitejs:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liaohainan liaohainan liaohainan left review comments

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev left review comments

Assignees
No one assigned
Labels
plugin: legacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zuochenxue @sapphi-red @patak-dev @liaohainan