Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload on restart with middleware mode (fixes #9038) #9040

Merged

Conversation

sapphi-red
Copy link
Member

Description

The reload after server restart was not working with middleware mode since 3.0.0-alpha.0.

fixes #9038
refs #6819

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added bug feat: hmr regression The issue only appears after a new release labels Jul 12, 2022
@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 5dac68c
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62ccdfc3f7ad1f000ab5bea6

@patak-dev patak-dev merged commit e372693 into vitejs:main Jul 12, 2022
@sapphi-red sapphi-red deleted the fix/reload-on-restart-middleware-mode branch July 12, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom dev server no longer reconnects
3 participants