fix(glob): server perf when globbing huge dirs #9425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vite:import-glob
plugin was unnecessarily watching globbed files (and doing so without checking for duplicates). This causes significant overhead when the file list is large (2K or more). It's also redundant to watch the files becausecreateServer()
already recursively watches the project's root directory.fixes #9391
Description
Additional context
I'd submit a unit test for this, but not yet sure how. The
test-serve
command is flaky on my machine (even without any of my changes).What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).