fix: handle errors during hasWorkspacePackageJSON function
#14394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p3-minor-bug
|
|
sapphi-red
force-pushed
the
fix/handle-errors-during-search-root-functions
branch
from
673497f to
2eb7a9c
Compare
sapphi-red
commented
Sep 17, 2023
Comment on lines
+30
to
+35
| try { | ||
| const content = JSON.parse(fs.readFileSync(path, 'utf-8')) || {} | ||
| return !!content.workspaces | ||
| } catch { | ||
| return false | ||
| } |
There was a problem hiding this comment.
fs.readFileSync might throw an error if path is not a file (isFileReadable doesn't check whether path is a file or not).
JSON.parse might throw an error if the content is not a valid JSON.
There was a problem hiding this comment.
Could we remove the if (!isFileReadable(path)) { check directly in this case since we can rely on the try catch instead?
There was a problem hiding this comment.
I think it's better to keep it. isFileReadable will filter the popular case (file doesn't exist) and we can avoid the slow try-catch.
It only affects if the project root is deep, but I think it's worth as this is only three lines of code.
sapphi-red
changed the title
hasWorkspacePackageJSON function
bluwy
approved these changes
Sep 18, 2023
sapphi-red
deleted the
fix/handle-errors-during-search-root-functions
branch
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found
hasWorkspacePackageJSONlacks error handling.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).