-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: esbuild glob import resolve error #15140
Merged
patak-dev
merged 5 commits into
vitejs:main
from
XiSenao:fix/esbuild-glob-import-resolve-error
Dec 1, 2023
Merged
fix: esbuild glob import resolve error #15140
patak-dev
merged 5 commits into
vitejs:main
from
XiSenao:fix/esbuild-glob-import-resolve-error
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiSenao
changed the title
Fix: esbuild glob import resolve error
fix: esbuild glob import resolve error
Nov 25, 2023
sapphi-red
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
sapphi-red
approved these changes
Dec 1, 2023
/ecosystem-ci run |
patak-dev
added
p3-minor-bug
An edge case that only affects very specific usage (priority)
feat: deps optimizer
Esbuild Dependencies Optimization
labels
Dec 1, 2023
📝 Ran ecosystem CI on
|
patak-dev
approved these changes
Dec 1, 2023
9 tasks
XiSenao
added a commit
to XiSenao/vite
that referenced
this pull request
Dec 9, 2023
This reverts commit 676804d.
XiSenao
added a commit
to XiSenao/vite
that referenced
this pull request
Dec 9, 2023
This reverts commit 676804d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feat: deps optimizer
Esbuild Dependencies Optimization
p3-minor-bug
An edge case that only affects very specific usage (priority)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #15129
Additional context
Esbuild
cannot trigger theonResolve
hook in plugins when parsing glob imports, and the current fix is borrowed from https://github.com/vitejs/vite/pull/14533/files#diff-00039b783552b3f2a608918986716e01b1a71996da1a8ad5493a102a1e969d7bR499-R504. But I don't know if any special scenarios are missed.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).