Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch): build watch fails when outDir is empty string #15979

Merged
merged 3 commits into from
Feb 20, 2024
Merged

fix(watch): build watch fails when outDir is empty string #15979

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acfa394
fix(watch): build watch fails when outDir is empty string
btea Feb 20, 2024
0c54596
chore: update
btea Feb 20, 2024
ec5aa43
refactor: update
btea Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions packages/vite/src/node/watch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,22 @@ export function resolveChokidarOptions(
config: ResolvedConfig,
options: WatchOptions | undefined,
): WatchOptions {
const { ignored = [], ...otherOptions } = options ?? {}
const { ignored: ignoredList, ...otherOptions } = options ?? {}
const ignored: WatchOptions['ignored'] = [
'**/.git/**',
'**/node_modules/**',
'**/test-results/**', // Playwright
glob.escapePath(config.cacheDir) + '/**',
...arraify(ignoredList || []),
]
if (config.build.outDir) {
ignored.push(
glob.escapePath(path.resolve(config.root, config.build.outDir)) + '/**',
)
}

const resolvedWatchOptions: WatchOptions = {
ignored: [
'**/.git/**',
'**/node_modules/**',
'**/test-results/**', // Playwright
glob.escapePath(config.cacheDir) + '/**',
glob.escapePath(path.resolve(config.root, config.build.outDir)) + '/**',
...arraify(ignored),
],
ignored,
ignoreInitial: true,
ignorePermissionErrors: true,
...otherOptions,
Expand Down