Bug Report: 17.0.0-rc.1 query arguments missing for product_user_product_id

[L3o-pold]

Overview of the Issue

Upgrading from Vitess 16.0.2 to 17.0.0-rc.1 we saw some query starting to fail with the error SQLSTATE[HY000]: General error: 1105 query arguments missing for product_user_product_id . Multiple requests are failing and they all have a JOIN it it. Here is a sample (reworked to avoid data leak)

Running an explain from MySQL:

{
   "OperatorType":"Route",
   "Variant":"EqualUnique",
   "Keyspace":{
      "Name":"commerce",
      "Sharded":true
   },
   "FieldQuery":"select product_user.id from product_user, product where 1 != 1",
   "Query":"select product_user.id from product_user, product where product_user.user_id = 'e2c4d5fb-9d00-4887-464e-e58f207bd7c9' and product_user.product_id = product.id",
   "Table":"product_user, product",
   "Values":[
      ":product_user_product_id"
   ],
   "Vindex":"unicode_loose_md5"
}

Running an explain from vtadmin fails with

"response": {
"error": {
 "message": "error running vtexplain: Code: INVALID_ARGUMENT for product_user_product_id...",
  "code": "unknown"
  },
  "ok": false
 },

With Vitess 16:

{
	"OperatorType": "VindexLookup",
	"Variant": "Equal",
	"Keyspace": {
		"Name": "commerce",
		"Sharded": true
	},
	"Values": [
		"VARCHAR(\"e2c4d5fb-9d00-4887-464e-e58f207bd7c9\")"
	],
	"Vindex": "product_user_keyspace_user_id",
	"Inputs": [
		{
			"OperatorType": "Route",
			"Variant": "IN",
			"Keyspace": {
				"Name": "commerce",
				"Sharded": true
			},
			"FieldQuery": "select user_id, keyspace_id from product_user_keyspace_user_id where 1 != 1",
			"Query": "select user_id, keyspace_id from product_user_keyspace_user_id where user_id in ::__vals",
			"Table": "product_user_keyspace_user_id",
			"Values": [
				":user_id"
			],
			"Vindex": "unicode_loose_md5"
		},
		{
			"OperatorType": "Route",
			"Variant": "ByDestination",
			"Keyspace": {
				"Name": "commerce",
				"Sharded": true
			},
			"FieldQuery": "select product_user.id from product_user, product where 1 != 1",
			"Query": "select product_user.id from product_user, product where product_user.user_id = 'e2c4d5fb-9d00-4887-464e-e58f207bd7c9' and product_user.product_id = product.id",
			"Table": "product_user, product"
		}
	]
}

Reproduction Steps

1. Deploy the following vschema:

{
    "sharded": true,
    "vindexes": {
        "product_user_keyspace_user_id": {
            "type": "consistent_lookup",
            "params": {
                "from": "user_id,id",
                "table": "commerce.product_user_keyspace_user_id",
                "to": "keyspace_id"
            },
            "owner": "product_user"
        },
        "unicode_loose_md5": {
            "type": "unicode_loose_md5"
        }
    },
    "tables": {
        "product_user": {
            "column_vindexes": [
                {
                    "column": "product_id",
                    "name": "unicode_loose_md5"
                },
                {
                    "name": "product_user_keyspace_user_id",
                    "columns": [
                        "user_id",
                        "id"
                    ]
                }
            ]
        },
        "product_user_keyspace_user_id": {
            "column_vindexes": [
                {
                    "column": "user_id",
                    "name": "unicode_loose_md5"
                }
            ]
        },
        "product": {
            "column_vindexes": [
                {
                    "column": "id",
                    "name": "unicode_loose_md5"
                }
            ]
        }
    }
}

2. Run

select `product_user`.`id`
from `product_user` 
inner join `product` on `product_user`.`product_id` = `product`.`id` 
where `product_user`.`user_id` = "e2c4d5fb-9d00-4887-464e-e58f207bd7c9";

4. View error

Binary Version

Version: 17.0.0-rc1 (Git revision d0caade2b46addc0e1050c10867e8b187d2a1d03 branch 'heads/v17.0.0-rc1') built on Tue Jun  6 14:21:23 UTC 2023 by vitess@buildkitsandbox using go1.20.4 linux/amd64

Operating System and Environment details

Docker

Log Fragments

Reverting vtgate (only) to 16.0.2 fixes the issue. No log appears with useful informations.

[mattlord]

/cc @vitessio/query-serving