Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for request_context when executing Online DDL via vtgate #13631

Closed
vkovacik opened this issue Jul 26, 2023 · 2 comments · Fixed by #13675
Closed
Assignees
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Feature

Comments

@vkovacik
Copy link

Feature Description

Background

We would like to use request_context feature of Online DDL to set an idempotency identifier. Unfortunately request_context is supported only when schema is applied via vtctlclient but not via vtgate.

Request

Add support for request_context when submitting DDL via vtgate. Suggested session variable could be @@ddl_request_context.
This is a follow up of the request raised in PR that implemented request_context.

Use Case(s)

We use Alembic for DB schema migrations. Each migration executes DDL statements via vtgate. The migration may be applied partially only to a subset of the shards. It is currently not possible to retry DDL (via vtgate) to fix the shards that had failed the migration.

@vkovacik vkovacik added Needs Triage This issue needs to be correctly labelled and triaged Type: Feature labels Jul 26, 2023
@shlomi-noach shlomi-noach self-assigned this Jul 27, 2023
@shlomi-noach shlomi-noach added Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jul 27, 2023
@shlomi-noach
Copy link
Contributor

Thank you for the feature request. It makes sense, I will look into it.

@shlomi-noach
Copy link
Contributor

Addressed by #13675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants