Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: vtorc profiling is not enabled #13637

Closed
dbussink opened this issue Jul 27, 2023 · 0 comments · Fixed by #13638
Closed

Bug Report: vtorc profiling is not enabled #13637

dbussink opened this issue Jul 27, 2023 · 0 comments · Fixed by #13638
Assignees
@dbussink
Labels
Component: Orchestrator Type: Bug

Comments

@dbussink
Copy link
Contributor

Overview of the Issue

All Vitess binaries should have profiling enabled by default. At least vtorc (but also some other supporting binaries) don't have this enabled. This is due to a lack of a call to servenv.Init in the main function for those binaries.

Reproduction Steps

Run vtorc and try to profile it.

Binary Version

v17.0 and later

Operating System and Environment details

All

Log Fragments

No response
@dbussink dbussink added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged labels Jul 27, 2023
@dbussink dbussink self-assigned this Jul 27, 2023
@dbussink dbussink added Component: Orchestrator and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jul 27, 2023
@dbussink dbussink mentioned this issue Jul 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbussink dbussink

Labels
Component: Orchestrator Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure to call servenv.Init when needed planetscale/vitess
1 participant
@dbussink