Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate OnlineDDL Launch #13718

Closed
Tracked by #13712
ajm188 opened this issue Aug 3, 2023 · 2 comments · Fixed by #13896
Closed
Tracked by #13712

Migrate OnlineDDL Launch #13718

ajm188 opened this issue Aug 3, 2023 · 2 comments · Fixed by #13896
Assignees
@shlomi-noach

Comments

@ajm188
Copy link
Contributor

ajm188 commented Aug 3, 2023

No description provided.

@ajm188 ajm188 mentioned this issue Aug 3, 2023
Closed
9 tasks
@ajm188
Copy link
Contributor Author

ajm188 commented Aug 24, 2023

@shlomi-noach For the "all" side on the CLI/rpc side at least, I was thinking we won't need separate commands (right now it's launch-all and launch <uuid>) instead similar to show where we take launch {<uuid>|'all'}. Thoughts?

@shlomi-noach
Copy link
Contributor

Agreed. We reuse the same command but the argument changes. This was also my re-implementation in vtctl: #12963

@shlomi-noach shlomi-noach mentioned this issue Aug 30, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlomi-noach shlomi-noach

Labels
None yet
Projects
Vtctld Service
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vtctldclient: support OnlineDDL complete, launch commands planetscale/vitess
2 participants
@shlomi-noach @ajm188