Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: vtctldclient vreplication commands allow workflows w/o tablet types #14293

Closed
mattlord opened this issue Oct 17, 2023 · 0 comments · Fixed by #14294
Closed

Bug Report: vtctldclient vreplication commands allow workflows w/o tablet types #14293

mattlord opened this issue Oct 17, 2023 · 0 comments · Fixed by #14294

Comments

@mattlord
Copy link
Contributor

mattlord commented Oct 17, 2023

Overview of the Issue

For a VReplication workflow to start, it must be able to use at least one valid tablet type.

Today we allow a user to explicitly (I would assume accidentally) specify an empty string which passes our validation.

We instead should return an error in this case as I cannot think of a valid use case for doing so.

Note
In this case you would have to cancel and re-create the workflow or use workflow update to update the tablet-types value.

Reproduction Steps

git checkout main && make build

cd examples/local

./101_initial_cluster.sh; ./201_customer_tablets.sh

vtctldclient MoveTables --workflow commerce2customer --target-keyspace customer create --source-keyspace commerce --tables "customer,corder" --tablet-types="fake"

vtctldclient MoveTables --workflow commerce2customer --target-keyspace customer create --source-keyspace commerce --tables "customer,corder" --tablet-types=""

vtctldclient workflow --keyspace customer update --workflow commerce2customer --tablet-types=""

Binary Version

vtgate version Version: 19.0.0-SNAPSHOT (Git revision 8575b170183bce389103d451965dc12070f4e36d branch 'main') built on Mon Oct 16 22:17:43 EDT 2023 by matt@pslord.local using go1.21.3 darwin/arm64

Operating System and Environment details

N/A

Log Fragments

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant