Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add DDL strategy flag linter #14372

Closed
shlomi-noach opened this issue Oct 26, 2023 · 0 comments · Fixed by #14373
Closed

Feature Request: add DDL strategy flag linter #14372

shlomi-noach opened this issue Oct 26, 2023 · 0 comments · Fixed by #14373
Assignees
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Feature

Comments

@shlomi-noach
Copy link
Contributor

Feature Description

Today, DDL strategy (whether --ddl-strategy flag in vtctldclient ApplySchema or @@ddl_strategy session variable), accepts a strategy and some flags. For example: vitess --postpone-completion.

Due to historical reasons, vitess parses the flags it knows about, and ignores the flags it does not know about, or rather, it sends them to the underlying schema change tool in the hope it knows what to do with them.

This is still the case, as it's possible to run --ddl-strategy="gh-ost --max-load=Threads_running=100".

But when it comes to the vitess (aka online) strategy, we can and should do a better job at linting the flags. Today, it's possible to enter vitess --ppstpone-completon, which is a typo. Vitess will silently ignore the flag. Instead, it should error.

Use Case(s)

Running Online DDL with strategy flags.

@shlomi-noach shlomi-noach added Type: Feature Needs Triage This issue needs to be correctly labelled and triaged Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Oct 26, 2023
@shlomi-noach shlomi-noach self-assigned this Oct 26, 2023
@shlomi-noach shlomi-noach removed the Needs Triage This issue needs to be correctly labelled and triaged label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant