Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: queryserver-config-*-pool-waiter-cap flags have no effect in v19 #15234

Closed
brendar opened this issue Feb 14, 2024 · 1 comment · Fixed by #15323
Closed

Bug Report: queryserver-config-*-pool-waiter-cap flags have no effect in v19 #15234

brendar opened this issue Feb 14, 2024 · 1 comment · Fixed by #15323
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Bug

Comments

@brendar
Copy link
Contributor

brendar commented Feb 14, 2024

Overview of the Issue

The new connection pool implementation from #14034 no longer uses ConnPoolConfig.MaxWaiters, which is set by vttablet flags queryserver-config-query-pool-waiter-cap, queryserver-config-stream-pool-waiter-cap, and queryserver-config-txpool-waiter-cap.

Reproduction Steps

Didn't reproduce manually, noticed while looking at the code

Binary Version

On tag: v19.0.0-rc1

Operating System and Environment details

n/a

Log Fragments

No response
@brendar brendar added Needs Triage This issue needs to be correctly labelled and triaged Type: Bug labels Feb 14, 2024
@dbussink
Copy link
Contributor

dbussink commented Feb 14, 2024 •
edited
Loading

@vmg should we deprecate these flags or would they still be useful and do we need to change something in the new pool implementation?

@vmg vmg mentioned this issue Feb 21, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tablet: remove max-waiters setting planetscale/vitess
2 participants
@dbussink @brendar