You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
include "vttablet-backup-cron" is called in each replica and rdonly types.
Therefore, it generate same CronJob named {cell}-{keyspace}-{shard}-backup twice.
I think this cronjob should be generated for replica tablet only. like below.
Overview of the Issue
When I tried to enable backup cron then I found 2 problems in helm chart.
Reproduction Steps
Steps to reproduce this issue:
Problem 1 : nil pointer evaluating interface {}.cron
Append below config to
examples/helm/101_initial_cluster.yaml
Execute helm template to check generated yaml
Then, you get an error.
$shard
object doesn't havecron
object. Whare is per shard cron config defined ?Problem 2 : Duplicated CronJob
Edit
helm/vitess/templates/_cron-jobs.tpl
to do workarround for problem 1Execute helm template again
Outputs:
2 same CronJob are generated.
Execute helm install
Got an error.
include "vttablet-backup-cron"
is called in eachreplica
andrdonly
types.Therefore, it generate same CronJob named {cell}-{keyspace}-{shard}-backup twice.
I think this cronjob should be generated for replica tablet only. like below.
At
vitess/helm/vitess/templates/_vttablet.tpl
Lines 155 to 156 in edb59bd
Operating system and Environment details
Minikube on macOS Catalina.
The text was updated successfully, but these errors were encountered: