From c7ff823b7e5525180fa22926b4c86cc3f74b979f Mon Sep 17 00:00:00 2001 From: Florent Poinsard Date: Wed, 26 Jul 2023 09:57:22 +0200 Subject: [PATCH 1/4] Update known issues in v16.x and v17 Signed-off-by: Florent Poinsard --- changelog/16.0/16.0.0/release_notes.md | 13 ++++++++++++- changelog/16.0/16.0.0/summary.md | 19 ++++++++++++++++++- changelog/16.0/16.0.1/release_notes.md | 20 +++++++++++++++++++- changelog/16.0/16.0.1/summary.md | 16 ++++++++++++++-- changelog/16.0/16.0.2/release_notes.md | 17 +++++++++++++++-- changelog/16.0/16.0.2/summary.md | 14 +++++++++++++- changelog/17.0/17.0.0/release_notes.md | 13 +++++++++++++ changelog/17.0/17.0.0/summary.md | 14 ++++++++++++++ 8 files changed, 118 insertions(+), 8 deletions(-) diff --git a/changelog/16.0/16.0.0/release_notes.md b/changelog/16.0/16.0.0/release_notes.md index 3de11f680bc..ba56c0d0965 100644 --- a/changelog/16.0/16.0.0/release_notes.md +++ b/changelog/16.0/16.0.0/release_notes.md @@ -6,6 +6,7 @@ - **[Known Issues](#known-issues)** - [MySQL & Xtrabackup known issue](#mysql-xtrabackup-ddl) - [VTTablet Restore Metrics](#vttablet-restore-metrics) + - [Schema-initialization stuck on semi-sync ACKs while upgrading to v16.0.0](#schema-init-upgrade) - **[Major Changes](#major-changes)** - **[Breaking Changes](#breaking-changes)** - [VTGate Advertised MySQL Version](#advertised-mysql-version) @@ -101,11 +102,21 @@ or > ALTER TABLE your_table ENGINE=InnoDB; ``` -#### VTTablet Restore Metrics +### VTTablet Restore Metrics As part of the VTTablet Sidecar Schema Maintenance Refactor in v16.0.0, we dropped the `local_metadata` table from the sidecar database schema. This table was storing a couple of metrics related to restores from backup, which have now been lost. They have been re-introduced in v17.0.0 as metrics that can be accessed from `/debug/vars`. +### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.0` + +During upgrades from `v15.x.x` to `v16.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +Eventually, `PromoteReplica` fails, and this fails the entire PRS call. + +A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). + +This issue will be addressed in the `v16.0.3` patch release. + ## Major Changes ### Breaking Changes diff --git a/changelog/16.0/16.0.0/summary.md b/changelog/16.0/16.0.0/summary.md index ac2cb5a5b6c..00c7e690660 100644 --- a/changelog/16.0/16.0.0/summary.md +++ b/changelog/16.0/16.0.0/summary.md @@ -3,7 +3,9 @@ ### Table of Contents - **[Known Issues](#known-issues)** - - [MySQL & Xtrabackup known issue](#mysql-xtrabackup-ddl) + - [MySQL & Xtrabackup known issue](#mysql-xtrabackup-ddl) + - [VTTablet Restore Metrics](#vttablet-restore-metrics) + - [Schema-initialization stuck on semi-sync ACKs while upgrading to v16.0.0](#schema-init-upgrade) - **[Major Changes](#major-changes)** - **[Breaking Changes](#breaking-changes)** - [VTGate Advertised MySQL Version](#advertised-mysql-version) @@ -99,6 +101,21 @@ or > ALTER TABLE your_table ENGINE=InnoDB; ``` +### VTTablet Restore Metrics + +As part of the VTTablet Sidecar Schema Maintenance Refactor in v16.0.0, we dropped the `local_metadata` table from the sidecar database schema. This table was storing a couple of metrics related to restores from backup, which have now been lost. +They have been re-introduced in v17.0.0 as metrics that can be accessed from `/debug/vars`. + +### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.0` + +During upgrades from `v15.x.x` to `v16.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +Eventually, `PromoteReplica` fails, and this fails the entire PRS call. + +A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). + +This issue will be addressed in the `v16.0.3` patch release. + ## Major Changes ### Breaking Changes diff --git a/changelog/16.0/16.0.1/release_notes.md b/changelog/16.0/16.0.1/release_notes.md index 6d9ea0d2017..235b26edc38 100644 --- a/changelog/16.0/16.0.1/release_notes.md +++ b/changelog/16.0/16.0.1/release_notes.md @@ -1,5 +1,18 @@ # Release of Vitess v16.0.1 -## Summary + +## Known Issues + +### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.1` + +During upgrades from `v15.x.x` to `v16.0.1`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +Eventually, `PromoteReplica` fails, and this fails the entire PRS call. + +A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). + +This issue will be addressed in the `v16.0.3` patch release. + +## Major Changes ### Upgrade to `go1.20.2` @@ -8,6 +21,11 @@ Below is a summary of this Go patch release. You can learn more [here](https://g > go1.20.2 (released 2023-03-07) includes a security fix to the crypto/elliptic package, as well as bug fixes to the compiler, the covdata command, the linker, the runtime, and the crypto/ecdh, crypto/rsa, crypto/x509, os, and syscall packages. +### Keyspace name validation in TopoServer + +Prior to v16.0.1, it was possible to create a keyspace with invalid characters, which would then be inaccessible to various cluster management operations. + +Keyspace names may no longer contain the forward slash ("/") character, and TopoServer's `GetKeyspace` and `CreateKeyspace` methods return an error if given such a name. ------------ The entire changelog for this release can be found [here](https://github.com/vitessio/vitess/blob/main/changelog/16.0/16.0.1/changelog.md). diff --git a/changelog/16.0/16.0.1/summary.md b/changelog/16.0/16.0.1/summary.md index 05381d735bc..1087734958f 100644 --- a/changelog/16.0/16.0.1/summary.md +++ b/changelog/16.0/16.0.1/summary.md @@ -1,4 +1,16 @@ -## Summary +## Known Issues + +### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.1` + +During upgrades from `v15.x.x` to `v16.0.1`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +Eventually, `PromoteReplica` fails, and this fails the entire PRS call. + +A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). + +This issue will be addressed in the `v16.0.3` patch release. + +## Major Changes ### Upgrade to `go1.20.2` @@ -11,5 +23,5 @@ Below is a summary of this Go patch release. You can learn more [here](https://g Prior to v16.0.1, it was possible to create a keyspace with invalid characters, which would then be inaccessible to various cluster management operations. - Keyspace names may no longer contain the forward slash ("/") character, and TopoServer's `GetKeyspace` and `CreateKeyspace` methods return an error if given such a name. +Keyspace names may no longer contain the forward slash ("/") character, and TopoServer's `GetKeyspace` and `CreateKeyspace` methods return an error if given such a name. diff --git a/changelog/16.0/16.0.2/release_notes.md b/changelog/16.0/16.0.2/release_notes.md index fd32cf7493d..6ff3e51ef7c 100644 --- a/changelog/16.0/16.0.2/release_notes.md +++ b/changelog/16.0/16.0.2/release_notes.md @@ -1,5 +1,18 @@ # Release of Vitess v16.0.2 -## Summary + +## Known Issues + +### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.2` + +During upgrades from `v15.x.x` to `v16.0.2`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +Eventually, `PromoteReplica` fails, and this fails the entire PRS call. + +A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). + +This issue will be addressed in the `v16.0.3` patch release. + +## Major Changes ### Upgrade to `go1.20.3` @@ -11,7 +24,7 @@ Below is a summary of this Go patch release. You can learn more [here](https://g ### EffectiveCallerId in Vtgate gRPC calls A new flag `grpc-use-static-authentication-callerid` is added to gate the behavior introduced in https://github.com/vitessio/vitess/pull/12050. -Earlier, we used to automatically set immediateCallerID to user from static authentication context that overrode the EffectiveCallerId. +Earlier, we used to automatically set immediateCallerID to user from static authentication context that overrode the EffectiveCallerId. ### Shard name validation in TopoServer diff --git a/changelog/16.0/16.0.2/summary.md b/changelog/16.0/16.0.2/summary.md index d8fbbc966d9..b2002fc559f 100644 --- a/changelog/16.0/16.0.2/summary.md +++ b/changelog/16.0/16.0.2/summary.md @@ -1,4 +1,16 @@ -## Summary +## Known Issues + +### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.2` + +During upgrades from `v15.x.x` to `v16.0.2`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +Eventually, `PromoteReplica` fails, and this fails the entire PRS call. + +A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). + +This issue will be addressed in the `v16.0.3` patch release. + +## Major Changes ### Upgrade to `go1.20.3` diff --git a/changelog/17.0/17.0.0/release_notes.md b/changelog/17.0/17.0.0/release_notes.md index cae79f9a5d7..44f04208b67 100644 --- a/changelog/17.0/17.0.0/release_notes.md +++ b/changelog/17.0/17.0.0/release_notes.md @@ -3,6 +3,8 @@ ### Table of Contents +- **[Known Issues](#known-issues)** + - [Schema-initialization stuck on semi-sync ACKs while upgrading to v17.0.0](#schema-init-upgrade) - **[Major Changes](#major-changes)** - **[Breaking Changes](#breaking-changes)** - [Default Local Cell Preference for TabletPicker](#tablet-picker-cell-preference) @@ -39,6 +41,17 @@ - [Deprecated `vtgr`](#deprecated-vtgr) - [Deprecated `k8stopo`](#deprecated-k8stopo) +## Known Issues +### Schema-initialization stuck on semi-sync ACKs while upgrading to `v17.0.0` + +During upgrades from `v16.x.x` to `v17.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +Eventually, `PromoteReplica` fails, and this fails the entire PRS call. + +A fix for this issue was merged on `release-17.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13411), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). + +This issue will be addressed in the `v17.0.1` patch release. + ## Major Changes diff --git a/changelog/17.0/17.0.0/summary.md b/changelog/17.0/17.0.0/summary.md index fdb1763a412..aa2ca63ae7c 100644 --- a/changelog/17.0/17.0.0/summary.md +++ b/changelog/17.0/17.0.0/summary.md @@ -2,6 +2,8 @@ ### Table of Contents +- **[Known Issues](#known-issues)** + - [Schema-initialization stuck on semi-sync ACKs while upgrading to v17.0.0](#schema-init-upgrade) - **[Major Changes](#major-changes)** - **[Breaking Changes](#breaking-changes)** - [Default Local Cell Preference for TabletPicker](#tablet-picker-cell-preference) @@ -38,6 +40,18 @@ - [Deprecated `k8stopo`](#deprecated-k8stopo) +## Known Issues +### Schema-initialization stuck on semi-sync ACKs while upgrading to `v17.0.0` + +During upgrades from `v16.x.x` to `v17.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +Eventually, `PromoteReplica` fails, and this fails the entire PRS call. + +A fix for this issue was merged on `release-17.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13411), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). + +This issue will be addressed in the `v17.0.1` patch release. + + ## Major Changes ### Breaking Changes From ed8c8e8f7b5811d5443b36bfa8f37982dafa9011 Mon Sep 17 00:00:00 2001 From: Florent Poinsard Date: Thu, 27 Jul 2023 11:49:38 +0200 Subject: [PATCH 2/4] address review suggestions Signed-off-by: Florent Poinsard --- changelog/16.0/16.0.0/release_notes.md | 8 +++++--- changelog/16.0/16.0.0/summary.md | 7 ++++--- changelog/16.0/16.0.1/release_notes.md | 5 ++--- changelog/16.0/16.0.1/summary.md | 5 ++--- changelog/16.0/16.0.2/release_notes.md | 5 ++--- changelog/16.0/16.0.2/summary.md | 5 ++--- changelog/17.0/17.0.0/release_notes.md | 5 ++--- changelog/17.0/17.0.0/summary.md | 5 ++--- 8 files changed, 21 insertions(+), 24 deletions(-) diff --git a/changelog/16.0/16.0.0/release_notes.md b/changelog/16.0/16.0.0/release_notes.md index ba56c0d0965..04312e55756 100644 --- a/changelog/16.0/16.0.0/release_notes.md +++ b/changelog/16.0/16.0.0/release_notes.md @@ -107,15 +107,17 @@ or As part of the VTTablet Sidecar Schema Maintenance Refactor in v16.0.0, we dropped the `local_metadata` table from the sidecar database schema. This table was storing a couple of metrics related to restores from backup, which have now been lost. They have been re-introduced in v17.0.0 as metrics that can be accessed from `/debug/vars`. +The original issue can be found [here](https://github.com/vitessio/vitess/issues/13336). + ### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.0` -During upgrades from `v15.x.x` to `v16.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. -The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +During upgrades from `<= v15.x.x` to `v16.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. +The issue is that if [semi-sync](https://vitess.io/docs/16.0/reference/features/mysql-replication/#semi-sync) is enabled, all of these writes get blocked indefinitely. Eventually, `PromoteReplica` fails, and this fails the entire PRS call. A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). -This issue will be addressed in the `v16.0.3` patch release. +This issue is fixed in `v16.0.3` and later patch releases. ## Major Changes diff --git a/changelog/16.0/16.0.0/summary.md b/changelog/16.0/16.0.0/summary.md index 00c7e690660..7f994122fda 100644 --- a/changelog/16.0/16.0.0/summary.md +++ b/changelog/16.0/16.0.0/summary.md @@ -106,15 +106,16 @@ or As part of the VTTablet Sidecar Schema Maintenance Refactor in v16.0.0, we dropped the `local_metadata` table from the sidecar database schema. This table was storing a couple of metrics related to restores from backup, which have now been lost. They have been re-introduced in v17.0.0 as metrics that can be accessed from `/debug/vars`. +The original issue can be found [here](https://github.com/vitessio/vitess/issues/13336). + ### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.0` -During upgrades from `v15.x.x` to `v16.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. -The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +During upgrades from `<= v15.x.x` to `v16.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database if [semi-sync](https://vitess.io/docs/16.0/reference/features/mysql-replication/#semi-sync) is enabled, all of these writes get blocked indefinitely. Eventually, `PromoteReplica` fails, and this fails the entire PRS call. A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). -This issue will be addressed in the `v16.0.3` patch release. +This issue is fixed in `v16.0.3` and later patch releases. ## Major Changes diff --git a/changelog/16.0/16.0.1/release_notes.md b/changelog/16.0/16.0.1/release_notes.md index 235b26edc38..953c30d0572 100644 --- a/changelog/16.0/16.0.1/release_notes.md +++ b/changelog/16.0/16.0.1/release_notes.md @@ -4,13 +4,12 @@ ### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.1` -During upgrades from `v15.x.x` to `v16.0.1`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. -The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +During upgrades from `<= v15.x.x` to `v16.0.1`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database if [semi-sync](https://vitess.io/docs/16.0/reference/features/mysql-replication/#semi-sync) is enabled, all of these writes get blocked indefinitely. Eventually, `PromoteReplica` fails, and this fails the entire PRS call. A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). -This issue will be addressed in the `v16.0.3` patch release. +This issue is fixed in `v16.0.3` and later patch releases. ## Major Changes diff --git a/changelog/16.0/16.0.1/summary.md b/changelog/16.0/16.0.1/summary.md index 1087734958f..9d6378fcbc3 100644 --- a/changelog/16.0/16.0.1/summary.md +++ b/changelog/16.0/16.0.1/summary.md @@ -2,13 +2,12 @@ ### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.1` -During upgrades from `v15.x.x` to `v16.0.1`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. -The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +During upgrades from `<= v15.x.x` to `v16.0.1`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database if [semi-sync](https://vitess.io/docs/16.0/reference/features/mysql-replication/#semi-sync) is enabled, all of these writes get blocked indefinitely. Eventually, `PromoteReplica` fails, and this fails the entire PRS call. A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). -This issue will be addressed in the `v16.0.3` patch release. +This issue is fixed in `v16.0.3` and later patch releases. ## Major Changes diff --git a/changelog/16.0/16.0.2/release_notes.md b/changelog/16.0/16.0.2/release_notes.md index 6ff3e51ef7c..0bea5205916 100644 --- a/changelog/16.0/16.0.2/release_notes.md +++ b/changelog/16.0/16.0.2/release_notes.md @@ -4,13 +4,12 @@ ### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.2` -During upgrades from `v15.x.x` to `v16.0.2`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. -The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +During upgrades from `<= v15.x.x` to `v16.0.2`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database if [semi-sync](https://vitess.io/docs/16.0/reference/features/mysql-replication/#semi-sync) is enabled, all of these writes get blocked indefinitely. Eventually, `PromoteReplica` fails, and this fails the entire PRS call. A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). -This issue will be addressed in the `v16.0.3` patch release. +This issue is fixed in `v16.0.3` and later patch releases. ## Major Changes diff --git a/changelog/16.0/16.0.2/summary.md b/changelog/16.0/16.0.2/summary.md index b2002fc559f..3b7a9d4cb5d 100644 --- a/changelog/16.0/16.0.2/summary.md +++ b/changelog/16.0/16.0.2/summary.md @@ -2,13 +2,12 @@ ### Schema-initialization stuck on semi-sync ACKs while upgrading to `v16.0.2` -During upgrades from `v15.x.x` to `v16.0.2`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. -The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +During upgrades from `<= v15.x.x` to `v16.0.2`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database if [semi-sync](https://vitess.io/docs/16.0/reference/features/mysql-replication/#semi-sync) is enabled, all of these writes get blocked indefinitely. Eventually, `PromoteReplica` fails, and this fails the entire PRS call. A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13441), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). -This issue will be addressed in the `v16.0.3` patch release. +This issue is fixed in `v16.0.3` and later patch releases. ## Major Changes diff --git a/changelog/17.0/17.0.0/release_notes.md b/changelog/17.0/17.0.0/release_notes.md index 44f04208b67..9900ded0e3c 100644 --- a/changelog/17.0/17.0.0/release_notes.md +++ b/changelog/17.0/17.0.0/release_notes.md @@ -44,13 +44,12 @@ ## Known Issues ### Schema-initialization stuck on semi-sync ACKs while upgrading to `v17.0.0` -During upgrades from `v16.x.x` to `v17.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. -The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +During upgrades from `<= v16.x.x` to `v17.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database if [semi-sync](https://vitess.io/docs/17.0/reference/features/mysql-replication/#semi-sync) is enabled, all of these writes get blocked indefinitely. Eventually, `PromoteReplica` fails, and this fails the entire PRS call. A fix for this issue was merged on `release-17.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13411), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). -This issue will be addressed in the `v17.0.1` patch release. +This issue is addressed in the `>= v17.0.1` patch releases. ## Major Changes diff --git a/changelog/17.0/17.0.0/summary.md b/changelog/17.0/17.0.0/summary.md index aa2ca63ae7c..8236d8d3e19 100644 --- a/changelog/17.0/17.0.0/summary.md +++ b/changelog/17.0/17.0.0/summary.md @@ -43,13 +43,12 @@ ## Known Issues ### Schema-initialization stuck on semi-sync ACKs while upgrading to `v17.0.0` -During upgrades from `v16.x.x` to `v17.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database. -The issue is that if semi-sync is enabled, all of these writes get blocked indefinitely. +During upgrades from `<= v16.x.x` to `v17.0.0`, as part of `PromoteReplica` call, the schema-init realizes that there are schema diffs to apply and ends up writing to the database if [semi-sync](https://vitess.io/docs/17.0/reference/features/mysql-replication/#semi-sync) is enabled, all of these writes get blocked indefinitely. Eventually, `PromoteReplica` fails, and this fails the entire PRS call. A fix for this issue was merged on `release-17.0` in [PR#13441](https://github.com/vitessio/vitess/pull/13411), read the [corresponding bug report to learn more](https://github.com/vitessio/vitess/issues/13426). -This issue will be addressed in the `v17.0.1` patch release. +This issue is addressed in the `>= v17.0.1` patch releases. ## Major Changes From af49e050749510075ec63366a2741117568ea7cb Mon Sep 17 00:00:00 2001 From: Florent Poinsard Date: Thu, 27 Jul 2023 14:53:46 +0200 Subject: [PATCH 3/4] add 13525 to known issues Signed-off-by: Florent Poinsard --- changelog/16.0/16.0.0/release_notes.md | 7 +++++++ changelog/16.0/16.0.0/summary.md | 7 +++++++ changelog/16.0/16.0.1/release_notes.md | 6 ++++++ changelog/16.0/16.0.1/summary.md | 6 ++++++ changelog/16.0/16.0.2/release_notes.md | 6 ++++++ changelog/16.0/16.0.2/summary.md | 7 +++++++ 6 files changed, 39 insertions(+) diff --git a/changelog/16.0/16.0.0/release_notes.md b/changelog/16.0/16.0.0/release_notes.md index 04312e55756..4f1320dbf19 100644 --- a/changelog/16.0/16.0.0/release_notes.md +++ b/changelog/16.0/16.0.0/release_notes.md @@ -7,6 +7,7 @@ - [MySQL & Xtrabackup known issue](#mysql-xtrabackup-ddl) - [VTTablet Restore Metrics](#vttablet-restore-metrics) - [Schema-initialization stuck on semi-sync ACKs while upgrading to v16.0.0](#schema-init-upgrade) + - [Broken downgrade from v17.x.x when init_db.sql turned on by default](#init-db-sql-turned-on) - **[Major Changes](#major-changes)** - **[Breaking Changes](#breaking-changes)** - [VTGate Advertised MySQL Version](#advertised-mysql-version) @@ -119,6 +120,12 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. +### Broken downgrade from v17.x.x when init_db.sql turned on by default + +In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.0` breaks due to `init_db.sql` needing write access. + +This issue is fixed in `>= v16.0.3` thanks to [PR #13525](https://github.com/vitessio/vitess/pull/13525) + ## Major Changes ### Breaking Changes diff --git a/changelog/16.0/16.0.0/summary.md b/changelog/16.0/16.0.0/summary.md index 7f994122fda..9d71650b842 100644 --- a/changelog/16.0/16.0.0/summary.md +++ b/changelog/16.0/16.0.0/summary.md @@ -6,6 +6,7 @@ - [MySQL & Xtrabackup known issue](#mysql-xtrabackup-ddl) - [VTTablet Restore Metrics](#vttablet-restore-metrics) - [Schema-initialization stuck on semi-sync ACKs while upgrading to v16.0.0](#schema-init-upgrade) + - [Broken downgrade from v17.x.x when init_db.sql turned on by default](#init-db-sql-turned-on) - **[Major Changes](#major-changes)** - **[Breaking Changes](#breaking-changes)** - [VTGate Advertised MySQL Version](#advertised-mysql-version) @@ -117,6 +118,12 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. +### Broken downgrade from v17.x.x when init_db.sql turned on by default + +In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.0` breaks due to `init_db.sql` needing write access. + +This issue is fixed in `>= v16.0.3` thanks to [PR #13525](https://github.com/vitessio/vitess/pull/13525). + ## Major Changes ### Breaking Changes diff --git a/changelog/16.0/16.0.1/release_notes.md b/changelog/16.0/16.0.1/release_notes.md index 953c30d0572..ad1fe45d5c2 100644 --- a/changelog/16.0/16.0.1/release_notes.md +++ b/changelog/16.0/16.0.1/release_notes.md @@ -11,6 +11,12 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. +### Broken downgrade from v17.x.x when init_db.sql turned on by default + +In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.1` breaks due to `init_db.sql` needing write access. + +This issue is fixed in `>= v16.0.3` thanks to [PR #13525](https://github.com/vitessio/vitess/pull/13525) + ## Major Changes ### Upgrade to `go1.20.2` diff --git a/changelog/16.0/16.0.1/summary.md b/changelog/16.0/16.0.1/summary.md index 9d6378fcbc3..e0f3ce98708 100644 --- a/changelog/16.0/16.0.1/summary.md +++ b/changelog/16.0/16.0.1/summary.md @@ -9,6 +9,12 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. +### Broken downgrade from v17.x.x when init_db.sql turned on by default + +In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.1` breaks due to `init_db.sql` needing write access. + +This issue is fixed in `>= v16.0.3` thanks to [PR #13525](https://github.com/vitessio/vitess/pull/13525) + ## Major Changes ### Upgrade to `go1.20.2` diff --git a/changelog/16.0/16.0.2/release_notes.md b/changelog/16.0/16.0.2/release_notes.md index 0bea5205916..f927a62261b 100644 --- a/changelog/16.0/16.0.2/release_notes.md +++ b/changelog/16.0/16.0.2/release_notes.md @@ -11,6 +11,12 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. +### Broken downgrade from v17.x.x when init_db.sql turned on by default + +In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.2` breaks due to `init_db.sql` needing write access. + +This issue is fixed in `>= v16.0.3` thanks to [PR #13525](https://github.com/vitessio/vitess/pull/13525) + ## Major Changes ### Upgrade to `go1.20.3` diff --git a/changelog/16.0/16.0.2/summary.md b/changelog/16.0/16.0.2/summary.md index 3b7a9d4cb5d..9779a0abd24 100644 --- a/changelog/16.0/16.0.2/summary.md +++ b/changelog/16.0/16.0.2/summary.md @@ -9,6 +9,13 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. +### Broken downgrade from v17.x.x when init_db.sql turned on by default + +In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.2` breaks due to `init_db.sql` needing write access. + +This issue is fixed in `>= v16.0.3` thanks to [PR #13525](https://github.com/vitessio/vitess/pull/13525) + + ## Major Changes ### Upgrade to `go1.20.3` From 41d2daa3ec40753be79814d257e4bb6bd0736073 Mon Sep 17 00:00:00 2001 From: Florent Poinsard Date: Thu, 27 Jul 2023 15:16:58 +0200 Subject: [PATCH 4/4] fix typo Signed-off-by: Florent Poinsard --- changelog/16.0/16.0.0/release_notes.md | 4 ++-- changelog/16.0/16.0.0/summary.md | 4 ++-- changelog/16.0/16.0.1/release_notes.md | 2 +- changelog/16.0/16.0.1/summary.md | 2 +- changelog/16.0/16.0.2/release_notes.md | 2 +- changelog/16.0/16.0.2/summary.md | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/changelog/16.0/16.0.0/release_notes.md b/changelog/16.0/16.0.0/release_notes.md index 4f1320dbf19..e17a74a8d0f 100644 --- a/changelog/16.0/16.0.0/release_notes.md +++ b/changelog/16.0/16.0.0/release_notes.md @@ -7,7 +7,7 @@ - [MySQL & Xtrabackup known issue](#mysql-xtrabackup-ddl) - [VTTablet Restore Metrics](#vttablet-restore-metrics) - [Schema-initialization stuck on semi-sync ACKs while upgrading to v16.0.0](#schema-init-upgrade) - - [Broken downgrade from v17.x.x when init_db.sql turned on by default](#init-db-sql-turned-on) + - [Broken downgrade from v17.x.x when super_read_only turned on by default](#init-db-sql-turned-on) - **[Major Changes](#major-changes)** - **[Breaking Changes](#breaking-changes)** - [VTGate Advertised MySQL Version](#advertised-mysql-version) @@ -120,7 +120,7 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. -### Broken downgrade from v17.x.x when init_db.sql turned on by default +### Broken downgrade from v17.x.x when super_read_only turned on by default In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.0` breaks due to `init_db.sql` needing write access. diff --git a/changelog/16.0/16.0.0/summary.md b/changelog/16.0/16.0.0/summary.md index 9d71650b842..c895a33130b 100644 --- a/changelog/16.0/16.0.0/summary.md +++ b/changelog/16.0/16.0.0/summary.md @@ -6,7 +6,7 @@ - [MySQL & Xtrabackup known issue](#mysql-xtrabackup-ddl) - [VTTablet Restore Metrics](#vttablet-restore-metrics) - [Schema-initialization stuck on semi-sync ACKs while upgrading to v16.0.0](#schema-init-upgrade) - - [Broken downgrade from v17.x.x when init_db.sql turned on by default](#init-db-sql-turned-on) + - [Broken downgrade from v17.x.x when super_read_only turned on by default](#init-db-sql-turned-on) - **[Major Changes](#major-changes)** - **[Breaking Changes](#breaking-changes)** - [VTGate Advertised MySQL Version](#advertised-mysql-version) @@ -118,7 +118,7 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. -### Broken downgrade from v17.x.x when init_db.sql turned on by default +### Broken downgrade from v17.x.x when super_read_only turned on by default In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.0` breaks due to `init_db.sql` needing write access. diff --git a/changelog/16.0/16.0.1/release_notes.md b/changelog/16.0/16.0.1/release_notes.md index ad1fe45d5c2..c1354eac4ee 100644 --- a/changelog/16.0/16.0.1/release_notes.md +++ b/changelog/16.0/16.0.1/release_notes.md @@ -11,7 +11,7 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. -### Broken downgrade from v17.x.x when init_db.sql turned on by default +### Broken downgrade from v17.x.x when super_read_only turned on by default In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.1` breaks due to `init_db.sql` needing write access. diff --git a/changelog/16.0/16.0.1/summary.md b/changelog/16.0/16.0.1/summary.md index e0f3ce98708..f9af9672ea1 100644 --- a/changelog/16.0/16.0.1/summary.md +++ b/changelog/16.0/16.0.1/summary.md @@ -9,7 +9,7 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. -### Broken downgrade from v17.x.x when init_db.sql turned on by default +### Broken downgrade from v17.x.x when super_read_only turned on by default In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.1` breaks due to `init_db.sql` needing write access. diff --git a/changelog/16.0/16.0.2/release_notes.md b/changelog/16.0/16.0.2/release_notes.md index f927a62261b..806cf87d208 100644 --- a/changelog/16.0/16.0.2/release_notes.md +++ b/changelog/16.0/16.0.2/release_notes.md @@ -11,7 +11,7 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. -### Broken downgrade from v17.x.x when init_db.sql turned on by default +### Broken downgrade from v17.x.x when super_read_only turned on by default In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.2` breaks due to `init_db.sql` needing write access. diff --git a/changelog/16.0/16.0.2/summary.md b/changelog/16.0/16.0.2/summary.md index 9779a0abd24..faef0207921 100644 --- a/changelog/16.0/16.0.2/summary.md +++ b/changelog/16.0/16.0.2/summary.md @@ -9,7 +9,7 @@ A fix for this issue was merged on `release-16.0` in [PR#13441](https://github.c This issue is fixed in `v16.0.3` and later patch releases. -### Broken downgrade from v17.x.x when init_db.sql turned on by default +### Broken downgrade from v17.x.x when super_read_only turned on by default In `v17.x.x` `super_read_only` is turned on by default meaning that downgrading from `v17` to `v16.0.2` breaks due to `init_db.sql` needing write access.