Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foreign key support for insert on duplicate key update #14638

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Add foreign key support for insert on duplicate key update #14638

merged 11 commits into from
Dec 12, 2023

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Nov 30, 2023 •
edited
Loading

Description

This PR adds foreign key support for insert queries having on duplicate key update with row values.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 30, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 30, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 30, 2023
@harshit-gangal harshit-gangal changed the title feat: add support for foreign key for insert on duplicate key update Add foreign key support for insert on duplicate key update Nov 30, 2023
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 30, 2023
@harshit-gangal
feat: added upsert engine primitive
fae6169 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
sizegen update
00962ee 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
insert on duplicate key update plan for single row insert
6d5c612 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
disallow autocommit for insert in upsert plan
59813b5 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
feat: update upsert engine to report correct affected rows, added uni…
7e7ad99 
…t and e2e tests

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
feat: update upsert engine to support multiple upserts
2cec09e 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
feat: plan insert on duplicate key update with multiple rows
213e423 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
feat: add +1 to rowaffected in upsert engine only if update returns a…
bc51d7e 
… rowaffected value, added e2e test for multiple rows

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review December 5, 2023 16:23
GuptaManan100
GuptaManan100 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me!

go/vt/vtgate/engine/upsert.go
Comment on lines +104 to +107
// To match mysql, need to report +1 on rows affected if there is any change.
if updQr.RowsAffected > 0 {
updQr.RowsAffected += 1
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that MySQL has this behaviour, but for the life of me, I can't understand why 😆

go/vt/vtgate/planbuilder/operators/upsert.go Outdated Show resolved Hide resolved
@harshit-gangal
Merge remote-tracking branch 'upstream/main' into fk-insert-dup
4bf4926 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
simplified the if condition check
b3b4edd 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
addressed review comments
50bd269 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit c680c16 into vitessio:main Dec 12, 2023
116 checks passed
@harshit-gangal harshit-gangal deleted the fk-insert-dup branch December 12, 2023 12:37
@harshit-gangal harshit-gangal mentioned this pull request Dec 13, 2023
Open
12 tasks
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@harshit-gangal @ejortegau
Add foreign key support for insert on duplicate key update (vitessio#…
31b0959 
…14638)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Feature
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-gangal @systay @GuptaManan100