-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi table deletes with foreign keys #15081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
requested review from
deepthi,
mattlord,
rohit-nayak-ps,
harshit-gangal,
systay,
frouioui,
arthurschreiber and
ajm188
as code owners
January 30, 2024 10:34
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 30, 2024
GuptaManan100
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 30, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… changes and fix the table extraction logic Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15081 +/- ##
==========================================
+ Coverage 47.29% 47.69% +0.39%
==========================================
Files 1137 1155 +18
Lines 238684 240266 +1582
==========================================
+ Hits 112895 114602 +1707
+ Misses 117168 117058 -110
+ Partials 8621 8606 -15 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
approved these changes
Jan 30, 2024
harshit-gangal
removed request for
arthurschreiber,
mattlord and
shlomi-noach
January 31, 2024 04:52
5 tasks
frouioui
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the changes to support multi-table delete queries along with foreign keys. After the changes in this PR, queries like the following now work -
Fuzzer tests for the same have been added and verified everything is working as intended.
Related Issue(s)
Checklist
Deployment Notes