Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async describe should not be an error #511

Closed
matyasf opened this issue Aug 16, 2024 · 2 comments · Fixed by #517
Closed

Async describe should not be an error #511

matyasf opened this issue Aug 16, 2024 · 2 comments · Fixed by #517

Comments

@matyasf
Copy link

matyasf commented Aug 16, 2024

vitest supports async describe, see vitest-dev/vitest#703 (comment) and vitest-dev/vitest#750

So this rule should be modified to support async https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/valid-describe-callback.md
@veritem
Copy link
Member

veritem commented Aug 16, 2024

a pr is welcome :D

@azu azu mentioned this issue Aug 26, 2024
Merged
@azu
Copy link
Contributor

azu commented Aug 26, 2024

I've created a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(valid-describe-callback): remove noAsyncDescribeCallback azu/eslint-plugin-vitest
3 participants
@azu @matyasf @veritem