fix(vite-node): deps.inline doesn't work (#3485)

packages/vite-node/src/externalize.ts

@@ -139,7 +139,7 @@ function matchExternalizePattern(id: string, moduleDirectories: string[], patter
     return true
   for (const ex of patterns) {
     if (typeof ex === 'string') {
-      if (moduleDirectories.some(dir => id.includes(join(dir, id))))
+      if (moduleDirectories.some(dir => id.includes(join(dir, ex))))
         return true
     }
     else {

test/core/projects/inline-lib/index.js

@@ -0,0 +1,4 @@
+export default function () {
+  // module doesn't exist in Node.js ESM, but exists in vite-node
+  return typeof module
+}

test/core/projects/inline-lib/package.json

@@ -0,0 +1,4 @@
+{
+  "type": "module",
+  "main": "index.js"
+}

test/core/test/inlined.test.ts

@@ -0,0 +1,7 @@
+// @ts-expect-error not typed lib
+import typeOfModule from 'inline-lib'
+import { expect, test } from 'vitest'
+
+test('inline lib has exports injected even though it is ESM', () => {
+  expect(typeOfModule()).toBe('object')
+})

test/core/vitest.config.ts

@@ -36,6 +36,7 @@ export default defineConfig({
       { find: '#', replacement: resolve(__dirname, 'src') },
       { find: '$', replacement: 'src' },
       { find: /^custom-lib$/, replacement: resolve(__dirname, 'projects', 'custom-lib') },
+      { find: /^inline-lib$/, replacement: resolve(__dirname, 'projects', 'inline-lib') },
     ],
   },
   test: {
@@ -63,6 +64,7 @@ export default defineConfig({
     },
     deps: {
       external: ['tinyspy', /src\/external/],
+      inline: ['inline-lib'],
       moduleDirectories: ['node_modules', 'projects', 'packages'],
     },
     alias: [