fix(runner): mark tests as skipped when beforeAll failed (#6524)

vitest-dev · Sep 25, 2024 · fb79792 · fb79792
1 parent 7727ca8
commit fb79792
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/packages/runner/src/run.ts b/packages/runner/src/run.ts
@@ -382,13 +382,19 @@ export async function runSuite(suite: Suite, runner: VitestRunner): Promise<void
   }
   else {
     try {
-      beforeAllCleanups = await callSuiteHook(
-        suite,
-        suite,
-        'beforeAll',
-        runner,
-        [suite],
-      )
+      try {
+        beforeAllCleanups = await callSuiteHook(
+          suite,
+          suite,
+          'beforeAll',
+          runner,
+          [suite],
+        )
+      }
+      catch (e) {
+        markTasksAsSkipped(suite, runner)
+        throw e
+      }
 
       if (runner.runSuite) {
         await runner.runSuite(suite)

diff --git a/test/reporters/tests/__snapshots__/junit.test.ts.snap b/test/reporters/tests/__snapshots__/junit.test.ts.snap
@@ -25,10 +25,12 @@ exports[`addFileAttribute true 1`] = `
 exports[`emits <failure> when beforeAll/afterAll failed 1`] = `
 "<?xml version="1.0" encoding="UTF-8" ?>
 <testsuites name="vitest tests" tests="8" failures="2" errors="0" time="...">
-    <testsuite name="basic.test.ts" timestamp="..." hostname="..." tests="8" failures="2" errors="0" skipped="2" time="...">
+    <testsuite name="basic.test.ts" timestamp="..." hostname="..." tests="8" failures="2" errors="0" skipped="4" time="...">
         <testcase classname="basic.test.ts" name="suite with beforeAll &gt; ok 1" time="...">
+            <skipped/>
         </testcase>
         <testcase classname="basic.test.ts" name="suite with beforeAll &gt; ok 2" time="...">
+            <skipped/>
         </testcase>
         <testcase classname="basic.test.ts" name="suite with beforeAll &gt; skip 1" time="...">
             <skipped/>