Warning when using with latest vite

[danielroe]

Describe the bug

When using with a customLogger the following error is printed.

[warn] (!) Experimental optimizeDeps.disabled and deps pre-bundling during build were removed in Vite 5.1.
    To disable the deps optimizer, set optimizeDeps.noDiscovery to true and optimizeDeps.include as undefined or empty.
    Please remove optimizeDeps.disabled from your config.

Reproduction

https://stackblitz.com/edit/github-66e6cf-qyzv3j?file=vitest.config.ts,package.json,tests/my-file.test.ts

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.14.0 - /usr/local/bin/pnpm
  npmPackages:
    vitest: ^1.2.2 => 1.2.2

Used Package Manager

npm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[hi-ogawa]

I was wondering why warning shows up only with customLogger. It looks like this is because Vitest sets logLevel: 'error':

vitest/packages/vitest/src/node/create.ts

Lines 24 to 25 in 9c01760

	const config: ViteInlineConfig = {
	logLevel: 'error',

vitest/packages/vitest/src/node/vite.ts

Lines 14 to 17 in 9c01760

	const server = await createServer({
	logLevel: 'error',
	...inlineConfig,
	})

so Vite's default logger silences warnings. But when using customLogger, Vite doesn't apply logLevel filtering, so warning shows up:
https://github.com/vitejs/vite/blob/775bb5026ee1d7e15b75c8829e7f528c1b26c493/packages/vite/src/node/logger.ts#L66-L72

Of course, Vitest should deal with deprecated optimizeDeps.disabled flag anyways, but is it possible that Nuxt's custom logger somehow misses logLevel coming from Vitest's inline config?

[danielroe]

Nuxt's customLogger isn't really expecting to be used in a vitest environment, so it's respecting the logLevel set in the vite config that is passed to it when it is created. Whereas vitest sets the logLevel after the Nuxt custom logger has already been created.

I have removed the customLogger from @nuxt/test-utils in any case but still thought it was worth raising here.

[hi-ogawa]

@danielroe Understood. Thanks for sharing the context and putting together an issue here!