Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage-v8 throws with new instances config #7212

Closed
6 tasks done
tsirlucas opened this issue Jan 11, 2025 · 0 comments · Fixed by #7231
Closed
6 tasks done

coverage-v8 throws with new instances config #7212

tsirlucas opened this issue Jan 11, 2025 · 0 comments · Fixed by #7231
Labels
feat: browser Issues and PRs related to the browser runner feat: coverage Issues and PRs related to the coverage feature p4-important Violate documented behavior or significantly improves performance (priority)

Comments

@tsirlucas
Copy link
Contributor

tsirlucas commented Jan 11, 2025

Describe the bug

after removin the old "name" config and replacing it with "instances", coverage-v8 started throwing:

{
  "browser": {
    "provider": "playwright"
  }
}

Use either:
{
  "browser": {
    "provider": "playwright",
    "name": "chromium"
  }
}

...or change your coverage provider to:
{
  "coverage": {
    "provider": "istanbul"
  }
}

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-9qgvnqv4?file=package.json

System Info

see reproduction link

Used Package Manager

npm

Validations

@sheremet-va sheremet-va added feat: coverage Issues and PRs related to the coverage feature feat: browser Issues and PRs related to the browser runner p4-important Violate documented behavior or significantly improves performance (priority) and removed pending triage labels Jan 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: browser Issues and PRs related to the browser runner feat: coverage Issues and PRs related to the coverage feature p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants