You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all: thanks for the fantastic work! It works like a charm. Perfect! :)
I was afraid the issue #147 is back. The fix mentioned by @vitobotta in #145 seemed to be gone in the current release (1.1.5).
But it was just a mistake on my part or a misinterpretation of the instructions. It says there:
If you don't want to specify the Hetzner token in the config file (for example if you want to use the tool with CI or want to safely commit the config file to a repository), then you can use the HCLOUD_TOKEN environment variable instead, which has precedence.
But it seems to be important, however, that there is NO token in the config file AT ALL or that the entry is commented out.
I therefore suggest formulating the README like this:
If you don't want to specify the Hetzner token in the config file (for example if you want to use the tool with CI or want to safely commit the config file to a repository), then you can use the HCLOUD_TOKEN environment variable instead. In that case, there must be no entry in the configuration file.
I can create a pull request on the main branch if that sounds good.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
First of all: thanks for the fantastic work! It works like a charm. Perfect! :)
I was afraid the issue #147 is back. The fix mentioned by @vitobotta in #145 seemed to be gone in the current release (1.1.5).
But it was just a mistake on my part or a misinterpretation of the instructions. It says there:
But it seems to be important, however, that there is NO token in the config file AT ALL or that the entry is commented out.
I therefore suggest formulating the README like this:
I can create a pull request on the main branch if that sounds good.
HTH
Gregor
Beta Was this translation helpful? Give feedback.
All reactions