You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
org.vividus.http.client.HttpClient#doHttpGet(java.net.URI) and org.vividus.http.client.HttpClient#doHttpHead(java.net.URI) should handle user info in the fully automated way:
the methods should convert user info provided as a part of URI to basic auth configuration;
these methods should be overloaded to accept parameter usePreemptiveBasicAuthIfAvailable;
the default behavior should be non-preemptive basic auth;
other methods accepting ClassicHttpRequest and/or HttpContext should be kept untouched;
Javadocs for updated and created methods should be created.
Once it's done, one more refactoring should be performed: add a new field to org.vividus.http.client.HttpResponse - org.apache.hc.core5.http.protocol.HttpContext used for HTTP request execution.
The following parts of the codebase should be refactored after the implementation:
org.vividus.http.client.HttpClient#doHttpGet(java.net.URI)
andorg.vividus.http.client.HttpClient#doHttpHead(java.net.URI)
should handle user info in the fully automated way:usePreemptiveBasicAuthIfAvailable
;ClassicHttpRequest
and/orHttpContext
should be kept untouched;Once it's done, one more refactoring should be performed: add a new field to
org.vividus.http.client.HttpResponse
-org.apache.hc.core5.http.protocol.HttpContext
used for HTTP request execution.The following parts of the codebase should be refactored after the implementation:
vividus/vividus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/PageSteps.java
Lines 332 to 344 in 2668dd0
vividus/vividus-plugin-web-app-to-rest-api/src/main/java/org/vividus/crawler/SiteMapParser.java
Lines 66 to 84 in 2668dd0
The text was updated successfully, but these errors were encountered: