[plugin-mobile-app] Add possibility to swipe the context #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Sep 3, 2021
| @@ -436,6 +436,9 @@ When I clear field located `accessibilityId(username)` | |||
|
|
|||
| Swipes to an element in either UP, DOWN, LEFT, or RIGHT direction with the specified swipe duration | |||
|
|
|||
| [INFO] | |||
| Step takes into account current context. If you need to perform swipe on the element, swith the context to the element. | |||
There was a problem hiding this comment.
Suggested change
| Step takes into account current context. If you need to perform swipe on the element, swith the context to the element. | |
| The step takes into account current context. If you need to perform swipe on the element, you need to switch the context to this element. |
| @@ -39,4 +41,7 @@ | |||
| List<WebElement> getAssertingWebElements(); | |||
|
|
|||
| boolean withAssertingWebElements(List<WebElement> elements, BooleanSupplier asserter); | |||
|
|
|||
| <R, T extends SearchContext> R calculateWhen(Class<T> expectedClazz, Function<T, R> valueCalculator, | |||
| Supplier<R> defaultValueProvider); | |||
There was a problem hiding this comment.
looks like not a part of UI context
| @@ -70,6 +72,7 @@ | |||
| void testGetCoordsNotIOS() | |||
| { | |||
| mockScrollbarActions(); | |||
| Mockito.doReturn(null).when(uiContext).getSearchContext(); | |||
There was a problem hiding this comment.
it's better to use static import for consistency
Comment on lines
138
to
140
| argThat(a -> { | ||
| return expectedCoords.equals(a.get()); | ||
| }))).thenReturn(expectedCoords); |
| import org.openqa.selenium.Dimension; | ||
| import org.openqa.selenium.Point; | ||
|
|
||
| public class SwipeArea |
There was a problem hiding this comment.
org.openqa.selenium.Rectangle
Codecov Report
@@ Coverage Diff @@
## master #1939 +/- ##
=========================================
Coverage 96.01% 96.01%
- Complexity 5294 5298 +4
=========================================
Files 751 751
Lines 15107 15117 +10
Branches 1029 1030 +1
=========================================
+ Hits 14505 14515 +10
Misses 469 469
Partials 133 133
Continue to review full report at Codecov.
|
ikalinin1
force-pushed
the
contextual-swipe
branch
from
ddb855a
to
3b1f692
Compare
ikalinin1
force-pushed
the
contextual-swipe
branch
from
3b1f692
to
137fef5
Compare
valfirst
requested changes
Sep 8, 2021
vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/TouchSteps.java
Show resolved
Hide resolved
valfirst
reviewed
Sep 8, 2021
ikalinin1
force-pushed
the
contextual-swipe
branch
from
137fef5
to
9b11330
Compare
|
Kudos, SonarCloud Quality Gate passed! |
valfirst
approved these changes
Sep 8, 2021
uarlouski
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1933