[bdd-engine] Add ability to load ExamplesTable bodies from variable #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #1948 +/- ##
============================================
- Coverage 96.01% 96.01% -0.01%
- Complexity 5297 5298 +1
============================================
Files 751 752 +1
Lines 15113 15116 +3
Branches 1030 1029 -1
============================================
+ Hits 14511 14513 +2
- Misses 469 470 +1
Partials 133 133
Continue to review full report at Codecov.
|
ikalinin1
reviewed
Sep 9, 2021
| @@ -12,6 +12,8 @@ bdd.batch-1.meta-filters=groovy: !skip && epic != 'vividus-plugin-ssh' && !local | |||
| bdd.batch-1.threads=5 | |||
| bdd.batch-1.story-execution-timeout=PT10M | |||
| bdd.variables.batch-1.locale=ca | |||
| bdd.variables.batch-1.filtered-examples-table={transformer=FILTERING, byColumnNames=column3}\ | |||
There was a problem hiding this comment.
does it make sense to put some variables into this table definition? global/scoped?
ikalinin1
reviewed
Sep 9, 2021
| import org.jbehave.core.steps.ParameterConverters; | ||
| import org.vividus.bdd.steps.VariableResolver; | ||
|
|
||
| public class VariableResolvingTableParsers extends TableParsers |
There was a problem hiding this comment.
Please add unit tests for the class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.