Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability import automated tests to zephyr #2319

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add ability import automated tests to zephyr #2319

wants to merge 4 commits into from

Conversation

TatianaTochko
Copy link
Contributor

Add ability to import automated tests to Zephyr:
add level properties for story and scenario
add ability to create jira issue
add ability to link requirement to test

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2021

This pull request introduces 1 alert when merging 1e9199b into eb591ca - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@codecov
Copy link

codecov bot commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #2319 (0e2da2a) into master (98381dc) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e2da2a differs from pull request most recent head 92d82b5. Consider uploading reports for the commit 92d82b5 to get more accurate results

@@            Coverage Diff            @@
##             master    #2319   +/-   ##
=========================================
  Coverage     96.67%   96.67%           
  Complexity     5534     5534           
=========================================
  Files           780      780           
  Lines         15835    15835           
  Branches       1050     1050           
=========================================
  Hits          15309    15309           
  Misses          410      410           
  Partials        116      116

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@valfirst valfirst requested review from uarlouski, valfirst, abudevich and ikalinin1 and removed request for valfirst December 23, 2021 07:43
@lgtm-com
Copy link

lgtm-com bot commented Dec 26, 2021

This pull request introduces 1 alert when merging ffc0ff8 into 9100e86 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 11, 2022

This pull request introduces 1 alert when merging fb1037d into a0e448d - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@TatianaTochko TatianaTochko force-pushed the add-ability-import-to-zephyr branch 4 times, most recently from 32573d8 to 004c982 Compare January 17, 2022 08:08
@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2022

This pull request introduces 1 alert when merging 004c982 into 09af67b - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@TatianaTochko TatianaTochko force-pushed the add-ability-import-to-zephyr branch 4 times, most recently from b863c68 to d6ccbe9 Compare January 17, 2022 09:32
@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2022

This pull request introduces 1 alert when merging d6ccbe9 into 09af67b - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2022

This pull request introduces 1 alert when merging b0c55ac into b49e863 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2022

This pull request introduces 1 alert when merging bb74db0 into b49e863 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2022

This pull request introduces 1 alert when merging 1eb61f8 into 14ca1f8 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2022

This pull request introduces 1 alert when merging 8625ed6 into 14ca1f8 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2022

This pull request introduces 1 alert when merging 4e07c8a into e5e0fce - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@TatianaTochko TatianaTochko force-pushed the add-ability-import-to-zephyr branch 2 times, most recently from 940b33d to 3ea79af Compare January 27, 2022 11:49
@lgtm-com
Copy link

lgtm-com bot commented Jan 27, 2022

This pull request introduces 1 alert when merging 3ea79af into a8b86c6 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2022

This pull request introduces 1 alert when merging b3010e8 into 10a59b5 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2022

This pull request introduces 1 alert when merging bf235d2 into 6f47289 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2022

This pull request introduces 1 alert when merging 22f841d into 7eac298 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Feb 1, 2022

This pull request introduces 1 alert when merging d1d7b2a into b8a0370 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@TatianaTochko TatianaTochko force-pushed the add-ability-import-to-zephyr branch 3 times, most recently from 1a62f99 to dce9162 Compare February 1, 2022 11:44
@lgtm-com
Copy link

lgtm-com bot commented Feb 1, 2022

This pull request introduces 1 alert when merging dce9162 into b8a0370 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Feb 9, 2022

This pull request introduces 1 alert when merging 06d907b into 70bce46 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

valfirst
valfirst requested changes Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@valfirst valfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review is not completed, because high number of critical comments are found, please fix them at first

docs/modules/integrations/pages/zephyr-exporter.adoc Outdated
Comment on lines 23 to 25
|`zephyr.exporter.export-results`
|true
|Property to export tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the purpose is not clear

docs/modules/integrations/pages/zephyr-exporter.adoc Outdated
|true
|Property to export tests

|`zephyr.exporter.level`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|`zephyr.exporter.level`
|`zephyr-exporter.test-entity`

docs/modules/integrations/pages/zephyr-exporter.adoc Outdated

|`zephyr.exporter.level`
|false
|Property to export stories on STORY or SCENARIO level
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the description is not clear

docs/modules/integrations/pages/zephyr-exporter.adoc Outdated
|`zephyr.exporter.jira-instance-key`
|false
|The key of the configured JIRA instance, in case of missing value it will be evaluated automatically based on issue keys being exported

|`zephyr.exporter.source-directory`
|true
|Path to directory with test execution JSON results.
|Path to directory with test JSON results.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason of this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This source includes not only execution results but also test details as description and scenario

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please elaborate on this

docs/modules/integrations/pages/zephyr-exporter.adoc Outdated

|`zephyr.exporter.update-execution-statuses-only`
|false
|Property for update existing executions statuses only.

|`zephyr.exporter.update-cases-on-export`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|`zephyr.exporter.update-cases-on-export`
|`zephyr-exporter.update-test-cases`

vividus-to-zephyr-exporter/src/main/java/org/vividus/zephyr/databind/TestCaseSerializer.java Outdated
{
Map<String, String> mapping = jiraConfigurationProvider.getFieldsMappingByProjectKey(projectKey);
String storyType = mapping.get(STORY_TYPE_FIELD_KEY);
if (Objects.nonNull(storyType))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple != null ?

vividus-to-zephyr-exporter/src/main/java/org/vividus/zephyr/exporter/ZephyrExporter.java Outdated
for (Story story : OutputReader.readStoriesFromJsons(zephyrExporterProperties.getSourceDirectory()))
{
TestCaseLevel testCaseLevel = zephyrExporterProperties.getLevel();
if (testCaseLevel.equals(TestCaseLevel.SCENARIO))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use == to compare enum-s

vividus-to-zephyr-exporter/src/main/java/org/vividus/zephyr/exporter/ZephyrExporter.java Outdated
{
exportTestExecution(testCase, configuration);
for (Story story : OutputReader.readStoriesFromJsons(zephyrExporterProperties.getSourceDirectory()))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor to avoid copy-pasted logic

vividus-to-zephyr-exporter/src/main/java/org/vividus/zephyr/model/TestCaseLevel.java Outdated
this.level = level;
}

public String getLevel()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it needed?

vividus-to-zephyr-exporter/src/main/java/org/vividus/zephyr/model/TestCaseStatus.java Outdated
UNKNOWN,
SKIPPED,
PASSED;
BROKEN(0, "notPerformed"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is BROKEN mapped to notPerformed?

@lgtm-com
Copy link

lgtm-com bot commented Feb 16, 2022

This pull request introduces 1 alert when merging 3fcfc47 into b0b5aad - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2022

This pull request introduces 1 alert when merging 92d82b5 into 0e2da2a - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed

@valfirst valfirst requested a review from a team as a code owner February 18, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst requested changes

@uarlouski uarlouski Awaiting requested review from uarlouski

@abudevich abudevich Awaiting requested review from abudevich

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TatianaTochko @valfirst @dzmitryasonau