Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin-web-app-to-rest-api] Avoid request sub-step reporting #3782

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[plugin-web-app-to-rest-api] Avoid request sub-step reporting #3782

wants to merge 5 commits into from

Conversation

EDbarvinsky
Copy link
Contributor

@EDbarvinsky EDbarvinsky commented Mar 30, 2023 •
edited
Loading

Closes #3644

@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #3782 (40344ea) into master (d2ed3ff) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3782      +/-   ##
============================================
- Coverage     97.08%   97.08%   -0.01%     
  Complexity     6143     6143              
============================================
  Files           854      854              
  Lines         17552    17552              
  Branches       1143     1143              
============================================
- Hits          17041    17040       -1     
- Misses          406      407       +1     
  Partials        105      105

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EDbarvinsky EDbarvinsky changed the title [DRAFT][plugin-web-app-to-rest-api] Avoid request/response reporting for resource checking steps [plugin-web-app-to-rest-api] Avoid request/response reporting for resource checking steps Mar 30, 2023
@EDbarvinsky EDbarvinsky changed the title [plugin-web-app-to-rest-api] Avoid request/response reporting for resource checking steps [plugin-web-app-to-rest-api] Avoid request/response attachments for resource checking steps Mar 30, 2023
@EDbarvinsky EDbarvinsky marked this pull request as ready for review March 30, 2023 12:26
@EDbarvinsky EDbarvinsky requested a review from a team as a code owner March 30, 2023 12:26
@EDbarvinsky EDbarvinsky changed the title [plugin-web-app-to-rest-api] Avoid request/response attachments for resource checking steps [plugin-web-app-to-rest-api] Avoid request sub-step reporting Apr 13, 2023
@valfirst
Copy link
Collaborator

The logging of the response time is lost.

Before the changes:

Screenshot 2023-04-19 at 11 17 50

After the changes:
Screenshot 2023-04-19 at 11 18 36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikalinin1 ikalinin1 ikalinin1 approved these changes

@uarlouski uarlouski Awaiting requested review from uarlouski uarlouski is a code owner automatically assigned from vividus-framework/maintainers

@valfirst valfirst Awaiting requested review from valfirst

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean-up allure report output of the resource checking step
3 participants
@EDbarvinsky @valfirst @ikalinin1