Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin-rest-api] Post executed requests in a curl syntax in allure attachments #4724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[plugin-rest-api] Post executed requests in a curl syntax in allure attachments #4724

wants to merge 1 commit into from

Conversation

abudevich
Copy link
Contributor

@abudevich abudevich commented Jan 11, 2024 •
edited by valfirst
Loading

Closes #328

@abudevich abudevich requested a review from a team as a code owner January 11, 2024 16:24
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efa5348) 97.41% compared to head (11b46ec) 97.42%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #4724   +/-   ##
=========================================
  Coverage     97.41%   97.42%           
- Complexity     6591     6606   +15     
=========================================
  Files           918      919    +1     
  Lines         18986    19038   +52     
  Branches       1269     1274    +5     
=========================================
+ Hits          18496    18548   +52     
  Misses          384      384           
  Partials        106      106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valfirst valfirst changed the title [plugin-rest-api] Post executed requests in a curl syntax in allure a… [plugin-rest-api] Post executed requests in a curl syntax in allure attachments Jan 12, 2024
valfirst
valfirst requested changes Jan 12, 2024
View reviewed changes
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/resources/org/vividus/http/attachment/api-message.ftl Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/PublishingAttachmentInterceptor.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/resources/org/vividus/http/attachment/api-message.ftl Show resolved Hide resolved
valfirst
valfirst requested changes Jan 15, 2024
View reviewed changes
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/PublishingAttachmentInterceptor.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/resources/org/vividus/http/attachment/api-message.ftl Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/resources/org/vividus/http/attachment/api-message.ftl Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/resources/org/vividus/http/attachment/api-message.ftl Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/test/java/org/vividus/http/CurlUtilsTests.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/test/java/org/vividus/http/CurlUtilsTests.java Outdated Show resolved Hide resolved
...dus-plugin-rest-api/src/test/java/org/vividus/http/PublishingAttachmentInterceptorTests.java Outdated Show resolved Hide resolved
@abudevich abudevich force-pushed the 328-curl branch 2 times, most recently from 38834ca to 14c97eb Compare January 17, 2024 08:31
@abudevich abudevich force-pushed the 328-curl branch 2 times, most recently from d3176fe to 48fbdf2 Compare January 19, 2024 08:57
valfirst
valfirst requested changes Jan 23, 2024
View reviewed changes
vividus-plugin-rest-api/src/main/java/org/vividus/http/ContentTypeHeaderParser.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/CurlUtils.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/PublishingAttachmentInterceptor.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/PublishingAttachmentInterceptor.java Outdated Show resolved Hide resolved
vividus-plugin-rest-api/src/main/java/org/vividus/http/PublishingAttachmentInterceptor.java Outdated
.orElseGet(() ->
Optional.ofNullable(ContentType.parseLenient(entity.getContentType()))
.orElse(ContentType.DEFAULT_TEXT).getMimeType()
);
isBinaryContent = entity instanceof ByteArrayEntity;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not always true:

  • if mimetype is textual, then it's not binary (even if it's of ByteArrayEntity)
  • if mimetype is not textual or not present, then we assume the content is binary, if it's not of StringEntity

@abudevich abudevich force-pushed the 328-curl branch 2 times, most recently from a3644a1 to 8ce42c5 Compare February 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst requested changes

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

@draker94 draker94 Awaiting requested review from draker94 draker94 is a code owner automatically assigned from vividus-framework/maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Http Client] Post executed requests in a curl syntax
2 participants
@abudevich @valfirst