From 0a16cb84f8402342c665e92503fd29bb26286c59 Mon Sep 17 00:00:00 2001
From: Vivien Nicolas <vnicolas@apple.com>
Date: Thu, 16 Jul 2020 13:39:24 +0200
Subject: [PATCH] Address review comments for src/platform/Darwin from #1497

---
 src/platform/Darwin/CHIPDevicePlatformEvent.h |  2 +-
 .../Darwin/ConfigurationManagerImpl.cpp       | 66 +------------------
 .../Darwin/ConfigurationManagerImpl.h         |  4 --
 3 files changed, 2 insertions(+), 70 deletions(-)

diff --git a/src/platform/Darwin/CHIPDevicePlatformEvent.h b/src/platform/Darwin/CHIPDevicePlatformEvent.h
index c888f4ff451744..de478fa98d41f5 100644
--- a/src/platform/Darwin/CHIPDevicePlatformEvent.h
+++ b/src/platform/Darwin/CHIPDevicePlatformEvent.h
@@ -58,7 +58,7 @@ enum InternalPlatformSpecificEventTypes
 } // namespace DeviceEventType
 
 /**
- * Represents platform-specific event information for Linux platforms.
+ * Represents platform-specific event information for Darwin platforms.
  */
 struct ChipDevicePlatformEvent final
 {
diff --git a/src/platform/Darwin/ConfigurationManagerImpl.cpp b/src/platform/Darwin/ConfigurationManagerImpl.cpp
index 8f877076a0b417..a6488ef763caa2 100644
--- a/src/platform/Darwin/ConfigurationManagerImpl.cpp
+++ b/src/platform/Darwin/ConfigurationManagerImpl.cpp
@@ -68,7 +68,7 @@ bool ConfigurationManagerImpl::_CanFactoryReset()
 
 void ConfigurationManagerImpl::_InitiateFactoryReset()
 {
-    PlatformMgr().ScheduleWork(DoFactoryReset);
+    ChipLogError(DeviceLayer, "InitiateFactoryReset not implemented");
 }
 
 CHIP_ERROR ConfigurationManagerImpl::_ReadPersistedStorageValue(::chip::Platform::PersistedStorage::Key key, uint32_t & value)
@@ -89,69 +89,5 @@ CHIP_ERROR ConfigurationManagerImpl::_WritePersistedStorageValue(::chip::Platfor
     return WriteConfigValue(configKey, value);
 }
 
-#if CHIP_DEVICE_CONFIG_ENABLE_WIFI_STATION
-CHIP_ERROR ConfigurationManagerImpl::GetWiFiStationSecurityType(Profiles::NetworkProvisioning::WiFiSecurityType & secType)
-{
-    CHIP_ERROR err;
-    uint32_t secTypeInt;
-
-    err = ReadConfigValue(kConfigKey_WiFiStationSecType, secTypeInt);
-    if (err == CHIP_NO_ERROR)
-    {
-        secType = (Profiles::NetworkProvisioning::WiFiSecurityType) secTypeInt;
-    }
-    return err;
-}
-
-CHIP_ERROR ConfigurationManagerImpl::UpdateWiFiStationSecurityType(Profiles::NetworkProvisioning::WiFiSecurityType secType)
-{
-    CHIP_ERROR err;
-    Profiles::NetworkProvisioning::WiFiSecurityType curSecType;
-
-    if (secType != Profiles::NetworkProvisioning::kWiFiSecurityType_NotSpecified)
-    {
-        err = GetWiFiStationSecurityType(curSecType);
-        if (err == CHIP_DEVICE_ERROR_CONFIG_NOT_FOUND || (err == CHIP_NO_ERROR && secType != curSecType))
-        {
-            uint32_t secTypeInt = secType;
-            err                 = WriteConfigValue(kConfigKey_WiFiStationSecType, secTypeInt);
-        }
-        SuccessOrExit(err);
-    }
-    else
-    {
-        err = ClearConfigValue(kConfigKey_WiFiStationSecType);
-        SuccessOrExit(err);
-    }
-
-exit:
-    return err;
-}
-#endif // CHIP_DEVICE_CONFIG_ENABLE_WIFI_STATION
-
-void ConfigurationManagerImpl::DoFactoryReset(intptr_t arg)
-{
-    CHIP_ERROR err;
-
-    ChipLogProgress(DeviceLayer, "Performing factory reset");
-
-    err = FactoryResetConfig();
-    if (err != CHIP_NO_ERROR)
-    {
-        ChipLogError(DeviceLayer, "FactoryResetConfig() failed: %s", ErrorStr(err));
-    }
-
-#if CHIP_DEVICE_CONFIG_ENABLE_THREAD
-
-    ChipLogProgress(DeviceLayer, "Clearing Thread provision");
-    ThreadStackMgr().ErasePersistentInfo();
-
-#endif // CHIP_DEVICE_CONFIG_ENABLE_THREAD
-
-    // Restart the system.
-    ChipLogProgress(DeviceLayer, "System restarting (not implemented)");
-    // TODO(#742): restart CHIP exe
-}
-
 } // namespace DeviceLayer
 } // namespace chip
diff --git a/src/platform/Darwin/ConfigurationManagerImpl.h b/src/platform/Darwin/ConfigurationManagerImpl.h
index 88b6b3f382b051..67dcf1b05c43a0 100644
--- a/src/platform/Darwin/ConfigurationManagerImpl.h
+++ b/src/platform/Darwin/ConfigurationManagerImpl.h
@@ -64,10 +64,6 @@ class ConfigurationManagerImpl final : public ConfigurationManager,
     friend ConfigurationManagerImpl & ConfigurationMgrImpl(void);
 
     static ConfigurationManagerImpl sInstance;
-
-    // ===== Private members reserved for use by this class only.
-
-    static void DoFactoryReset(intptr_t arg);
 };
 
 /**