From 556e8db104b5a3c92c122563dfa74db36abc695c Mon Sep 17 00:00:00 2001 From: Veronica Berglyd Olsen <1619840+vkbo@users.noreply.github.com> Date: Fri, 16 Aug 2024 09:33:38 +0200 Subject: [PATCH 1/4] Add some text about spell checking to editor docs --- docs/source/usage_writing.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/docs/source/usage_writing.rst b/docs/source/usage_writing.rst index a1b59c679..2a646e1ec 100644 --- a/docs/source/usage_writing.rst +++ b/docs/source/usage_writing.rst @@ -40,6 +40,24 @@ Any :term:`references` in the editor can be opened in the viewer by m the label and pressing :kbd:`Ctrl+Return`. You can also control-click them with your mouse. +Spell Checking +-------------- + +A third party library called Enchant is used for spell checking in the editor. The controls for +spell checking can be found in the **Tools** menu. You can also set spell checking language in +**Project Settings**. + +This spell checking library comes with support for custom words that you can add by selecting +"Add Word to Dictionary" from the context menu. The custom words are managed on a per-project +basis, and can the list of words can be edited from the **Project Word List** tool available from +the **Tools** menu. + +.. note:: + + Generally, spell check languages are collected from your operating system, but on Windows they + are not. See :ref:`a_custom_dict` for how to add spell check languages on Windows. + + Editor Auto-Completer --------------------- From 66986b88f8f829336493c23a7f44fa78366f6773 Mon Sep 17 00:00:00 2001 From: Veronica Berglyd Olsen <1619840+vkbo@users.noreply.github.com> Date: Sun, 1 Sep 2024 21:41:26 +0200 Subject: [PATCH 2/4] Improve the spell checking info a little --- docs/source/usage_writing.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/source/usage_writing.rst b/docs/source/usage_writing.rst index 2a646e1ec..b59ff19fc 100644 --- a/docs/source/usage_writing.rst +++ b/docs/source/usage_writing.rst @@ -48,14 +48,14 @@ spell checking can be found in the **Tools** menu. You can also set spell checki **Project Settings**. This spell checking library comes with support for custom words that you can add by selecting -"Add Word to Dictionary" from the context menu. The custom words are managed on a per-project -basis, and can the list of words can be edited from the **Project Word List** tool available from -the **Tools** menu. +"Add Word to Dictionary" from the context menu when a word is highlighted by the spell checker as +misspelled. The custom words are managed on a per-project basis, and can the list of words can be +edited from the **Project Word List** tool available from the **Tools** menu. .. note:: - Generally, spell check languages are collected from your operating system, but on Windows they - are not. See :ref:`a_custom_dict` for how to add spell check languages on Windows. + Generally, spell checking dictionaries are collected from your operating system, but on Windows + they are not. See :ref:`a_custom_dict` for how to add spell checking dictionaries on Windows. Editor Auto-Completer From 15803cf0a300b2245c50afa8862d2cc64fbac5a5 Mon Sep 17 00:00:00 2001 From: Veronica Berglyd Olsen <1619840+vkbo@users.noreply.github.com> Date: Tue, 17 Sep 2024 15:33:37 +0200 Subject: [PATCH 3/4] Bump version and update changelog --- CHANGELOG.md | 30 ++++++++++++++++++++++++++++++ novelwriter/__init__.py | 6 +++--- sample/nwProject.nwx | 4 ++-- 3 files changed, 35 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index be568eb25..9a1417987 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,35 @@ # novelWriter Changelog +## Version 2.5.2 [2024-09-17] + +### Release Notes + +This is a patch release that fixes a series of issues mostly affecting dialogue highlighting in the +document viewer. The way the text is formatted in the viewer changed a lot in 2.5, and there were a +few issues with the new implementation. The tab stop distance setting was also ignored, but has now +been fixed as well. + +### Detailed Changelog + +**Bugfixes** + +* Fixed an issue where the tab stop distance setting was being ignored in the document viewer. It + must be set again every time a document is loaded. Issue #1996. PR #2014. +* Fixed an issue with overlapping formatting markers when processing text into new formats. This + issues was introduced when dialogue highlighting was added to the document viewer and manuscript + build. It arises because start and end of dialogue can occur on the same character as other + formatting, and then the order these markers are processed matters. This was not properly handled + in the code. Issue #2012. PR #2014. +* Dialogue highlighting is now only applied to plain text paragraphs, not comments, headings, and + other places where there should be no dialogue. Issue #2013. PR #2014. +* Note documents no longer get dialogue highlighting. Issue #2011. PR #2014. + +**Documentation** + +* Added a section about spell checking in the documentation. PR #2015. + +---- + ## Version 2.5.1 [2024-07-28] ### Release Notes diff --git a/novelwriter/__init__.py b/novelwriter/__init__.py index f40caddbe..76480febe 100644 --- a/novelwriter/__init__.py +++ b/novelwriter/__init__.py @@ -47,9 +47,9 @@ __author__ = "Veronica Berglyd Olsen" __maintainer__ = "Veronica Berglyd Olsen" __email__ = "code@vkbo.net" -__version__ = "2.5.1" -__hexversion__ = "0x020501f0" -__date__ = "2024-07-28" +__version__ = "2.5.2" +__hexversion__ = "0x020502f0" +__date__ = "2024-09-17" __status__ = "Stable" __domain__ = "novelwriter.io" diff --git a/sample/nwProject.nwx b/sample/nwProject.nwx index c4d06852f..b9e8108c4 100644 --- a/sample/nwProject.nwx +++ b/sample/nwProject.nwx @@ -1,6 +1,6 @@ - - + + Sample Project Jane Smith From 8dc28ddbee6f9db50c32f9eda4dd6c11d51cbc24 Mon Sep 17 00:00:00 2001 From: Veronica Berglyd Olsen <1619840+vkbo@users.noreply.github.com> Date: Tue, 17 Sep 2024 15:45:30 +0200 Subject: [PATCH 4/4] Add signing request to windows build --- .github/workflows/build_win.yml | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_win.yml b/.github/workflows/build_win.yml index 086b71035..ca7c7009e 100644 --- a/.github/workflows/build_win.yml +++ b/.github/workflows/build_win.yml @@ -28,7 +28,27 @@ jobs: - name: Build Setup Installer run: python pkgutils.py build-win-exe - - name: Upload Artifacts + - name: Upload Unsigned Artifacts + id: upload-unsigned-artifact + uses: actions/upload-artifact@v4 + with: + name: Win-Setup + path: dist/*.exe + if-no-files-found: error + retention-days: 14 + + - name: Submit Signing Request + uses: signpath/github-action-submit-signing-request@v1 + with: + api-token: "${{ secrets.SIGNPATH_API_TOKEN }}" + organization-id: "0471e52c-66fa-4e9a-bfb9-36167095ca3f" + project-slug: "novelWriter" + signing-policy-slug: "release-signing" + github-artifact-id: "${{ steps.upload-unsigned-artifact.outputs.artifact-id }}" + wait-for-completion: true + output-artifact-directory: "dist/" + + - name: Upload Signed Artifacts uses: actions/upload-artifact@v4 with: name: Win-Setup