Disable irrelevant buttons in the New Project dialog

[HeyMyian]

Originally posted in #1699 (comment)

[vkbo]

The New Project doesn't do anything when you're in the New Project page, but the Browse and Open buttons perform their actions regardless of what page is visible, so one of the two solutions below is probably sensible.

When pressing the Browse or Open button when the New Project page is active:

1. Do nothing at all. Just block the action.
2. Switch back to the Project Overview page, but don't perform the actions requested.

I think 1 is the cleanest, but 2 gives some implied feedback about why the buttons aren't doing anything.

Since the two pages are just stacked on top of each other, dropping out of the New Project page doesn't do anything to the already filled in content, so you can just press "New Project" to go back again.

[HeyMyian]

Do these buttons come with a distinct "inactive" style maybe?

[vkbo]

Not sure. Open and Cancel are standard buttons, and they are different between operating systems. These dialog button boxes are designed to integrate with the style of the host OS, so it's harder to predict how they turn out. As you've seen, disabling a button or control doesn't necessarily mean it looks inactive. The toggle switch looks inactive because I designed it, including the code that paints the different parts, and chose to make it very clear.

I think perhaps option 1 is the safest solution.

[vkbo]

Actually, it's only the Open button that needs handling. Browse has nothing to do with either page, and is a functionality all on its own, like Cancel. That's why I put it where it is in the first place. I put Open there because otherwise it would be inconsistent, since Open is a system standard button.

I think I will just block the open action when the project list isn't visible and leave it at that.