Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique classes in views #177

Closed
piotrm73 opened this issue Aug 24, 2023 · 4 comments
Closed

unique classes in views #177

piotrm73 opened this issue Aug 24, 2023 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@piotrm73
Copy link

I have suggestion to give unique classes in views, because now timeGridDay, timeGridWeek and resourceTimeGridWeek all are in '.ec-week' container nad this makes it difficult to customize views in css...
for example I have many resources in resourceTimeGridWeek and I had to change some css there but it spoils the timeGridDay and timeGridWeek views

@vkurko
Copy link
Owner

vkurko commented Aug 24, 2023

Actually, it has already been implemented in v2.1.0. Please check this comment.

@vkurko
Copy link
Owner

vkurko commented Aug 28, 2023

I hope I can close this issue.

@vkurko vkurko closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
@vkurko vkurko added the duplicate This issue or pull request already exists label Aug 28, 2023
@piotrm73
Copy link
Author

ok. I installed latest version and fortunatelly it's working on older nodejs...but I have just one more suggestion about resource view

image

it would be good to separate .toolbar from the rest (.ec-header, .ece-all-day, ec-body) because when it's many resources you must use oferflow:auto or scroll, and it would be good to attach overflow to container with just resources data, and toolbar should not be scrolled then

@vkurko
Copy link
Owner

vkurko commented Aug 30, 2023

Thanks for the suggestion. For a large number of resources, this view would be more suitable. Hope it gets implemented someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants