Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 functionality issues #359

Open
c0repwn3r opened this issue Oct 22, 2024 · 6 comments
Open

Svelte 5 functionality issues #359

c0repwn3r opened this issue Oct 22, 2024 · 6 comments

Comments

@c0repwn3r
Copy link

Works great in svelte 4. Tried in svelte 5 - this lib is incompatible with the new event system & some buttons don't appear correctly (copy-pasting the demo options, with all plugins installed):
image

@ngDuyAnh
Copy link

Yes, there is some initialize rendering problems with the component in Svelte 5. I had to downgrade to Svelte 4 to use it properly.

@vkurko
Copy link
Owner

vkurko commented Oct 28, 2024

Thanks, Svelte 5 support is in the works.

@ondrejrohon
Copy link

@vkurko need help?

@vkurko
Copy link
Owner

vkurko commented Nov 1, 2024

Overall, the experience of #235 can be useful. I don't have a specific plan of action right now (or rather, I initially wanted to rewrite everything from scratch, but it turned out to be too expensive, and I put this idea aside).

So if you can suggest rewriting some part of the code so that it works well in Svelte 5, then please, I'm open to such suggestions.

@Mathnerd314
Copy link

Well, the SMUI library is an example - first they simply added <svelte:options runes={false} /> to each file, then they are (still) migrating the files one by one, e.g. in this commit, changing those to runes={true}. There is an automigrate script npx sv migrate svelte-5, but it isn't complete, so doing it incrementally makes more sense IMO.

@James3UK
Copy link

James3UK commented Nov 24, 2024

@vkurko
The main change required is just renaming the store to something other than 'state' because it clashes with the svelte 5 state rune.
e.g setContext('state'); just needs to be setContext('calendarState'); or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants