You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the theme-color meta tag is set to #FFFFFF, even when the user switches to dark mode using the toggle button. In my opinion, it would look pretty if the theme color is set to the TOC bg color or the main page bg color. Here are some screenshots on MacOS Safari:
Use Case
It looks more modern and changing theme color based on dark/light mode seems like the right choice.
Safari on Mac is currently the only desktop browser that support theme-color. It is mostly supported on browsers on phones. On mobile devices, the doc web page has a header on top of the page. It will probably look best if on mobile, the theme-color is set to the color of this header.
I'm interested to hear from you which color you would prefer (desktop/mobile, dark/light). Let me know, and then I'll look at implementing this.
Acknowledgements
I may be able to implement this feature request
This feature might incur a breaking change
Version used
V 0.3.4 4485f1c
Environment details (OS name and version, etc.)
V full version: V 0.3.4 4485f1c
OS: macos, macOS, 13.4, 22F66
Processor: 4 cpus, 64bit, little endian, Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz
This discussion was converted from issue #18500 on June 27, 2023 10:03.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Describe the feature
Currently, the
theme-color
meta tag is set to#FFFFFF
, even when the user switches to dark mode using the toggle button. In my opinion, it would look pretty if the theme color is set to the TOC bg color or the main page bg color. Here are some screenshots on MacOS Safari:Use Case
It looks more modern and changing theme color based on dark/light mode seems like the right choice.
Proposed Solution
In
./cmd/tools/vdoc/theme/doc.js
Other Information
Safari on Mac is currently the only desktop browser that support theme-color. It is mostly supported on browsers on phones. On mobile devices, the doc web page has a header on top of the page. It will probably look best if on mobile, the theme-color is set to the color of this header.
I'm interested to hear from you which color you would prefer (desktop/mobile, dark/light). Let me know, and then I'll look at implementing this.
Acknowledgements
Version used
V 0.3.4 4485f1c
Environment details (OS name and version, etc.)
V full version: V 0.3.4 4485f1c
OS: macos, macOS, 13.4, 22F66
Processor: 4 cpus, 64bit, little endian, Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz
getwd: /Users/yochem/Documents/nv
vexe: /Users/yochem/Documents/nv/v
vexe mtime: 2023-06-20 12:57:53
vroot: OK, value: /Users/yochem/Documents/nv
VMODULES: OK, value: /Users/yochem/.local/share/vmodules
VTMP: OK, value: /tmp/v_501
Git version: git version 2.41.0
Git vroot status: weekly.2023.25-5-g4485f1ca-dirty
.git/config present: true
CC version: Apple clang version 14.0.3 (clang-1403.0.22.14.1)
thirdparty/tcc status: thirdparty-macos-amd64 46662e2
Beta Was this translation helpful? Give feedback.
All reactions