-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-Wimpure-v
should apply to tests as well as compiling
#20696
Comments
|
For example: |
I think In any case, if |
It does work without
|
Try for example: |
Yes, I understand, but I'm saying it should "just work" without having to know a special sequence of things to type. |
But it does already. Currently |
If what you are arguing for, is towards making |
I think this is a special case, and should be displayed in all cases. Otherwise, it can cause confusion as to why tests won't work with other backends, unless you open the source and scan for |
FYI coreutils CI failed due to this issue. |
Describe the bug
Adding
-Wimpure-v
will give a warning if C code is used in plain .v files:However, this is only when compiling. When C code is used in a test file, there is no warning given.
Reproduction Steps
x.v
x_test.v
Expected Behavior
Warnings for both
.v
and_test.v
when-Wimpure-v
is specified.Current Behavior
Possible Solution
Test files with backend specific code can't be used when testing other backends, so they should be put in backend specific files.
Additional Information/Context
No response
V version
V 0.4.4 804a7bd
Environment details (OS name and version, etc.)
Note
You can use the 👍 reaction to increase the issue's priority for developers.
Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.
The text was updated successfully, but these errors were encountered: