-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved syntax for CRR / CRDT creation #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex made a really good point here: tursodatabase/libsql#147 (comment) this'll make `crr` creation a bit more ergonomic for the base extension
for: `CREATE foo_crr AS CausalLengthSet` Or should it be `CLSet`?
Note that this does not replace the old APIs of
This is new syntax for people allergic to mutations done through |
…IRTUAL TABLE` xCreate
You can't alter the CRRs via the virtual tables yet (although the existing alter APIs still work). Will do that in a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creation of
crr
s via virtual table declaration.Instead of:
Users can now:
which will create a table
foo
as a CRR.foo_schema
exists as.. an unfortunate requirement but it has some benefits.Altering CRRs would now be:
rather than
Neither of these are ideal but the insertion against the schema table seems less error prone. It could also, maybe, allow more declarative schema management:
Where we use our auto_migrate plugin to apply the correct schema modifications to update foo to the newly supplied schema.
Future iterations will extend this syntax to allow specifying CRDT type on a per-column basis.
Fixes #181