Skip to content

Commit

Permalink
[Bugfix] Fix incorrect llava next feature size calculation (#8496)
Browse files Browse the repository at this point in the history
  • Loading branch information
zyddnys authored Sep 20, 2024
1 parent 7f9c890 commit 0f961b3
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions vllm/model_executor/models/llava_next.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,17 +87,19 @@ def _get_llava_next_num_unpadded_features(
current_height = npatches * num_patch_height
current_width = npatches * num_patch_width

aspect_ratio = original_width / original_height
original_aspect_ratio = original_width / original_height
current_aspect_ratio = current_width / current_height

if aspect_ratio > current_aspect_ratio:
new_height = (original_height * current_width) // original_width
if original_aspect_ratio > current_aspect_ratio:
scale_factor = current_width / original_width
new_height = int(original_height * scale_factor)
padding = (current_height - new_height) // 2
current_height -= padding * 2
current_height -= 2 * padding
else:
new_width = (original_width * current_height) // original_height
scale_factor = current_height / original_height
new_width = int(original_width * scale_factor)
padding = (current_width - new_width) // 2
current_width -= padding * 2
current_width -= 2 * padding

unpadded_features = current_height * current_width
newline_features = current_height
Expand Down

0 comments on commit 0f961b3

Please sign in to comment.