-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Performance]: Profile & optimize the BlockManagerV2 #4536
Comments
What we want to profile:
For high-throughput use-case:
Other cases that are important (perhaps we make separate tasks):
In terms of how to profile, use vllm/benchmarks/benchmark_latency.py Lines 178 to 187 in c3c2903
|
@robertgshaw2-neuralmagic can you assign Alex |
This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you! |
This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you! |
Proposal to improve performance
We've recently rewritten the block management subsystem for better testability. We need to profile it under real load to make sure it is performant enough to replace the block manager V1, and fix any issues.
We should do this once the block manager v2 is feature complete (still missing a few items).
Known issue:
num_total_tokens
is O(N^2) instead of O(N) (see [Core] Enable prefix caching with block manager v2 enabled #4142 (comment))The text was updated successfully, but these errors were encountered: