You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Motivation:
We have made great strides in enforcing code quality and consistency within our Python codebase, particularly with the recent MyPy integration. To maintain a high standard of code quality throughout the project, we should apply similar formatting and style guidelines to our C++ and CUDA code.
Proposal:
Integrate clang-format into our format.sh code quality workflow to automatically enforce consistent formatting for C++ and CUDA files. This will ensure that all code adheres to the Google C++ style guide, making the codebase more readable and maintainable.
Benefits:
Consistent formatting across the entire codebase, including C++ and CUDA files.
Improved code readability and maintainability.
Reduced cognitive overhead for developers working with multiple languages within the project.
Alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Yes! I believe @LiuXiaoxuanPKU also mentioned something like this before. The only concern/corner case this needs to address is some "vendor" files need to skip formatting like exllama or awq kernels. (to minimize the diff)
🚀 The feature, motivation and pitch
Motivation:
We have made great strides in enforcing code quality and consistency within our Python codebase, particularly with the recent MyPy integration. To maintain a high standard of code quality throughout the project, we should apply similar formatting and style guidelines to our C++ and CUDA code.
Proposal:
Integrate
clang-format
into ourformat.sh
code quality workflow to automatically enforce consistent formatting for C++ and CUDA files. This will ensure that all code adheres to the Google C++ style guide, making the codebase more readable and maintainable.Benefits:
Alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: