From f5ab5873d79a479f2631f26802bdbf1775e50773 Mon Sep 17 00:00:00 2001 From: Alexey Kondratiev Date: Wed, 18 Sep 2024 01:28:55 +0000 Subject: [PATCH 1/5] Re-enabling Entrypoints tests on ROCm, exluding ones that fail --- .buildkite/run-amd-test.sh | 8 ++++++++ .buildkite/test-pipeline.yaml | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.buildkite/run-amd-test.sh b/.buildkite/run-amd-test.sh index 6659440135ff4..d51ae81d82425 100755 --- a/.buildkite/run-amd-test.sh +++ b/.buildkite/run-amd-test.sh @@ -93,6 +93,14 @@ if [[ $commands == *" kernels "* ]]; then --ignore=kernels/test_sampler.py" fi +#ignore certain Entrypoints tests +if [[ $commands == *" entrypoints/openai "* ]]; then + commands=${commands//" entrypoints/openai "/" entrypoints/openai \ + --ignore=entrypoints/openai/test_audio.py \ + --ignore=entrypoints/openai/test_encoder_decoder.py \ + --ignore=entrypoints/openai/test_oot_registration.py \ + --ignore=entrypoints/openai/test_shutdown.py "} + PARALLEL_JOB_COUNT=8 # check if the command contains shard flag, we will run all shards in parallel because the host have 8 GPUs. if [[ $commands == *"--shard-id="* ]]; then diff --git a/.buildkite/test-pipeline.yaml b/.buildkite/test-pipeline.yaml index 63ce9bff7d4c1..fa6b38a3c6d52 100644 --- a/.buildkite/test-pipeline.yaml +++ b/.buildkite/test-pipeline.yaml @@ -82,7 +82,7 @@ steps: - label: Entrypoints Test # 20min working_dir: "/vllm-workspace/tests" fast_check: true - #mirror_hardwares: [amd] + mirror_hardwares: [amd] source_file_dependencies: - vllm/ commands: From 811133baf97840bfcb4e7973d99b8830d6dd1421 Mon Sep 17 00:00:00 2001 From: "Alexey Kondratiev(AMD)" <143633163+alexeykondrat@users.noreply.github.com> Date: Wed, 18 Sep 2024 10:03:00 -0400 Subject: [PATCH 2/5] Fixing typo --- .buildkite/run-amd-test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.buildkite/run-amd-test.sh b/.buildkite/run-amd-test.sh index d51ae81d82425..b22bf5aebf631 100755 --- a/.buildkite/run-amd-test.sh +++ b/.buildkite/run-amd-test.sh @@ -100,6 +100,7 @@ if [[ $commands == *" entrypoints/openai "* ]]; then --ignore=entrypoints/openai/test_encoder_decoder.py \ --ignore=entrypoints/openai/test_oot_registration.py \ --ignore=entrypoints/openai/test_shutdown.py "} +fi PARALLEL_JOB_COUNT=8 # check if the command contains shard flag, we will run all shards in parallel because the host have 8 GPUs. From b43932ce49cd0c77ab519ee2418052a634fb53ef Mon Sep 17 00:00:00 2001 From: "Alexey Kondratiev(AMD)" <143633163+alexeykondrat@users.noreply.github.com> Date: Wed, 18 Sep 2024 22:04:22 -0400 Subject: [PATCH 3/5] Enabling entrypoints/openai/test_shutdown.py --- .buildkite/run-amd-test.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.buildkite/run-amd-test.sh b/.buildkite/run-amd-test.sh index b22bf5aebf631..45288dbadf10a 100755 --- a/.buildkite/run-amd-test.sh +++ b/.buildkite/run-amd-test.sh @@ -98,8 +98,7 @@ if [[ $commands == *" entrypoints/openai "* ]]; then commands=${commands//" entrypoints/openai "/" entrypoints/openai \ --ignore=entrypoints/openai/test_audio.py \ --ignore=entrypoints/openai/test_encoder_decoder.py \ - --ignore=entrypoints/openai/test_oot_registration.py \ - --ignore=entrypoints/openai/test_shutdown.py "} + --ignore=entrypoints/openai/test_oot_registration.py "} fi PARALLEL_JOB_COUNT=8 From 0eca416ee6f97b341f94b9295ac199f2a140f7b5 Mon Sep 17 00:00:00 2001 From: Alexey Kondratiev Date: Thu, 19 Sep 2024 15:47:44 +0000 Subject: [PATCH 4/5] Disabling openai/test_accuracy.py --- .buildkite/run-amd-test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.buildkite/run-amd-test.sh b/.buildkite/run-amd-test.sh index e95f7797023b1..45b20c9447c7d 100755 --- a/.buildkite/run-amd-test.sh +++ b/.buildkite/run-amd-test.sh @@ -97,6 +97,7 @@ fi #ignore certain Entrypoints tests if [[ $commands == *" entrypoints/openai "* ]]; then commands=${commands//" entrypoints/openai "/" entrypoints/openai \ + --ignore=entrypoints/openai/test_accuracy.py \ --ignore=entrypoints/openai/test_audio.py \ --ignore=entrypoints/openai/test_encoder_decoder.py \ --ignore=entrypoints/openai/test_oot_registration.py "} From 1561e2e7d0ae4350e4ca3e168a143dadccc199ed Mon Sep 17 00:00:00 2001 From: Alexey Kondratiev Date: Fri, 20 Sep 2024 16:32:32 +0000 Subject: [PATCH 5/5] Removing entrypoints/openai/test_embedding.py test --- .buildkite/run-amd-test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.buildkite/run-amd-test.sh b/.buildkite/run-amd-test.sh index 45b20c9447c7d..df201cdc7c554 100755 --- a/.buildkite/run-amd-test.sh +++ b/.buildkite/run-amd-test.sh @@ -100,6 +100,7 @@ if [[ $commands == *" entrypoints/openai "* ]]; then --ignore=entrypoints/openai/test_accuracy.py \ --ignore=entrypoints/openai/test_audio.py \ --ignore=entrypoints/openai/test_encoder_decoder.py \ + --ignore=entrypoints/openai/test_embedding.py \ --ignore=entrypoints/openai/test_oot_registration.py "} fi