-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync testing/toss. #223
Comments
+1 |
Agreed, synchronous toss calls would make the tests much more readable and plus the --junitreport produce unstructured report files. Since each frisby.create() produce a different file, in case of callbacks chain you end up with one file per callback instead of one file for the whole chain. This is probably due to the fact that frisby.toss() wrap test execution in a describe() and it(). If we could somehow move the describe() outside of frisby, every toss() call would be sequential and people could decide how to structure their spec suite which define reports files structure. |
+1 got into this problem in my first 10 minutes of frisby |
I have to say it bite me too. ( Did not even think it was async ) Any test sequence including consecutive tests will be nightmare to write. |
+1 |
Yes. Callbacks are uncalled for a and very ugly in this context. |
Could be useful to have a system like expressjs middlewares where each middleware perform a specific action.
Where "signup" and other middlewares receive an object (where previously called middleware can set session data). Like this:
|
I wrote a function to help avoiding callback hell: https://gist.github.com/dakk/c701743a6df931210af1571efe5ade35 |
I got into this problem in my first 10 minutes with Frisby, I'll continue using Newman as long as they fix or work in a method to decide running sequence of our tests. |
This is less of an issue in v2 using promise-style |
It should support synchronous toss calls. Currently, you need to create a huge chain of callbacks if you want to run a sequence of steps within the same test.
The text was updated successfully, but these errors were encountered: