Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold and italics adjacent to parentheses are ignored. #174

Closed
rcrowley opened this issue Nov 21, 2012 · 4 comments
Closed

Bold and italics adjacent to parentheses are ignored. #174

rcrowley opened this issue Nov 21, 2012 · 4 comments

Comments

@rcrowley
Copy link

This is bold.

This is italics.

(This should be bold.)

(This should be italics.)

( This is bold. )

( This is italics. )

( This should be bold.)

( This should be italics.)

(This should be bold. )

(This should be italics. )

@brief
Copy link
Contributor

brief commented Nov 21, 2012

Good catch. It also applies to square brackets -- [This should be bold] vs [ This should be bold ].

As an aside, this issue should probably be moved to sundown.

@aprescott
Copy link

Weirdly, this doesn't work on GitHub but does work with Redcarpet?

puts Redcarpet::Markdown.new(Redcarpet::Render::SmartyHTML).render(%q{
(**This should be bold.**)

(*This should be italics.*)

(**This should be bold.**)

(*This should be italics.*)

(**This should be bold**)
(*This should be italics*)

[**This should be bold**]
[*This should be italics*]
})

output:

<p>(<strong>This should be bold.</strong>)</p>

<p>(<em>This should be italics.</em>)</p>

<p>(<strong>This should be bold.</strong>)</p>

<p>(<em>This should be italics.</em>)</p>

<p>(<strong>This should be bold</strong>)
(<em>This should be italics</em>)</p>

<p>[<strong>This should be bold</strong>]
[<em>This should be italics</em>]</p>

Perhaps GitHub isn't running the same version of Redcarpet and this was fixed?

@robin850
Copy link
Collaborator

robin850 commented Apr 7, 2013

Github isn't using Redcarpet anymore to parse markdown. See #212 for details. I can't reproduce this issue on my machine and @aprescott doesn't have the issue. We can close this for now. By the way, thanks @aprescott, you are often contributing to fix issues. It's too kind! 😄

@robin850 robin850 closed this as completed Apr 7, 2013
@aprescott
Copy link

My pleasure!

I wonder if we can get the bug fixed with GitHub just for good measure. I'll report it so they at least know (although it'd surprise me if they didn't already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants