Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Improve code format for comment #1018

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

SataQiu
Copy link
Contributor

@SataQiu SataQiu commented Apr 3, 2019

Issue Ref: [Issue number related to this PR or None]

Description:
Improve code format for comment

[PR Description]
Improve code format for comment

TODOs:

  • Ready to review
  • Automated Tests
  • Docs

@SataQiu
Copy link
Contributor Author

SataQiu commented Apr 3, 2019

I submitted a pull request but CI check failed.

I don't know how my patch will be causing that failure. Can I get any help?

@SataQiu
Copy link
Contributor Author

SataQiu commented Apr 3, 2019

I have run make validation on my machine, it worked well. I don't know why the CI failed.

@andresmgot
Copy link
Contributor

Hi @SataQiu, you are hitting this issue: #1012 (comment)

The new version of golang changed the behaviour of go vet. Could you update the script described in that comment?

@SataQiu
Copy link
Contributor Author

SataQiu commented Apr 8, 2019

@andresmgot Thanks for your feedback. I'd be happy to work it out!

@SataQiu SataQiu mentioned this pull request Apr 8, 2019
3 tasks
@andresmgot
Copy link
Contributor

Thanks for the follow up PR! Can you rebase master in this one? Now your issue should be fixed.

@SataQiu
Copy link
Contributor Author

SataQiu commented Apr 9, 2019

@andresmgot Thank you. That's what I'm going to do.

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@andresmgot andresmgot merged commit 84fa853 into vmware-archive:master Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants